From e169ac8108a9f52086acb79b7718a195e27a4143 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 3 Jan 2009 00:11:28 +0000 Subject: [PATCH] properly restart epoll_wait() if it got interrupted by a signal git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@57800 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/unix/epolldispatcher.cpp | 44 ++++++++++++++++++++++++------------ 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/src/unix/epolldispatcher.cpp b/src/unix/epolldispatcher.cpp index f509c7be25..336506016c 100644 --- a/src/unix/epolldispatcher.cpp +++ b/src/unix/epolldispatcher.cpp @@ -23,6 +23,7 @@ #include "wx/unix/private/epolldispatcher.h" #include "wx/unix/private.h" +#include "wx/stopwatch.h" #ifndef WX_PRECOMP #include "wx/log.h" @@ -162,26 +163,41 @@ bool wxEpollDispatcher::Dispatch(int timeout) { epoll_event events[16]; - const int e_num = epoll_wait - ( - m_epollDescriptor, - events, - WXSIZEOF(events), - timeout == TIMEOUT_INFINITE ? -1 : timeout - ); + // the code below relies on TIMEOUT_INFINITE being -1 so that we can pass + // timeout value directly to epoll_wait() which interprets -1 as meaning to + // wait forever and would need to be changed if the value of + // TIMEOUT_INFINITE ever changes + wxCOMPILE_TIME_ASSERT( TIMEOUT_INFINITE == -1, UpdateThisCode ); - if ( e_num == -1 ) + wxMilliClock_t timeEnd; + if ( timeout != -1 ) + timeEnd = wxGetLocalTimeMillis(); + + int rc; + for ( ;; ) { - if ( errno != EINTR ) - { - wxLogSysError(_("Waiting for IO on epoll descriptor %d failed"), - m_epollDescriptor); + rc = epoll_wait(m_epollDescriptor, events, WXSIZEOF(events), timeout); + if ( rc != -1 || errno != EINTR ) + break; + + // we got interrupted, update the timeout and restart + if ( timeout == -1 ) + continue; + + timeout = wxMilliClockToLong(timeEnd - wxGetLocalTimeMillis()); + if ( timeout < 0 ) return false; - } + } + + if ( rc == -1 ) + { + wxLogSysError(_("Waiting for IO on epoll descriptor %d failed"), + m_epollDescriptor); + return false; } bool gotEvents = false; - for ( epoll_event *p = events; p < events + e_num; p++ ) + for ( epoll_event *p = events; p < events + rc; p++ ) { wxFDIOHandler * const handler = (wxFDIOHandler *)(p->data.ptr); if ( !handler ) -- 2.45.2