From cffff062b34764a1b0978a06cf3788403cd73f3b Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Tue, 2 Dec 2008 18:10:58 +0000 Subject: [PATCH] no changes, just added a TODO comment git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@57072 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/xrc/xmlres.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/xrc/xmlres.cpp b/src/xrc/xmlres.cpp index bd6c432084..fc16e6ec42 100644 --- a/src/xrc/xmlres.cpp +++ b/src/xrc/xmlres.cpp @@ -1193,14 +1193,20 @@ wxXmlNode *wxXmlResourceHandler::GetParamNode(const wxString& param) while (n) { if (n->GetType() == wxXML_ELEMENT_NODE && n->GetName() == param) + { + // TODO: check that there are no other properties/parameters with + // the same name and log an error if there are (can't do this + // right now as I'm not sure if it's not going to break code + // using this function in unintentional way (i.e. for + // accessing other things than properties), for example + // wxBitmapComboBoxXmlHandler almost surely does return n; + } n = n->GetNext(); } return NULL; } - - bool wxXmlResourceHandler::IsOfClass(wxXmlNode *node, const wxString& classname) { return node->GetAttribute(wxT("class"), wxEmptyString) == classname; -- 2.45.2