From cb28cc9e757a89926ab437141218db72973b655d Mon Sep 17 00:00:00 2001 From: Ryan Norton Date: Thu, 7 Apr 2005 20:49:34 +0000 Subject: [PATCH] Fix Seeking to end of wxStreamInputStream (patch [ 1178834 ] string stream bad m_len check) git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@33418 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/common/sstream.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/common/sstream.cpp b/src/common/sstream.cpp index 4228a8a19e..0e783fb640 100644 --- a/src/common/sstream.cpp +++ b/src/common/sstream.cpp @@ -36,7 +36,9 @@ // construction/destruction // ---------------------------------------------------------------------------- -wxStringInputStream::wxStringInputStream(const wxString& s) +// TODO: Do we want to include the null char in the stream? If so then +// just add +1 to m_len in the ctor +wxStringInputStream::wxStringInputStream(const wxString& s) #if wxUSE_UNICODE : m_str(s), m_buf(wxMBConvUTF8().cWX2MB(s).release()), m_len(strlen(m_buf)) #else @@ -91,7 +93,7 @@ wxFileOffset wxStringInputStream::OnSysSeek(wxFileOffset ofs, wxSeekMode mode) return wxInvalidOffset; } - if ( ofs < 0 || wx_static_cast(size_t, ofs) >= m_len ) + if ( ofs < 0 || wx_static_cast(size_t, ofs) > m_len ) return wxInvalidOffset; m_pos = wx_static_cast(size_t, ofs); @@ -154,9 +156,10 @@ size_t wxStringOutputStream::OnSysWrite(const void *buffer, size_t size) // the literal length m_str->Append(wxString(p, m_conv, size)); - // return number of bytes actually written + // update position m_pos += size; + // return number of bytes actually written return size; } -- 2.45.2