From c9ab63f44f0dba014aeb803803a5e8717adcef35 Mon Sep 17 00:00:00 2001 From: Julian Smart Date: Wed, 6 Apr 2005 21:13:28 +0000 Subject: [PATCH] As yet unsuccessful attempt to set the focus to the choice control. Also removed unnecessary border style setting code. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@33393 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/choicebk.h | 3 +++ include/wx/generic/propdlg.h | 9 +++++++-- src/generic/propdlg.cpp | 29 ++++++++++++++++++++++++++--- 3 files changed, 36 insertions(+), 5 deletions(-) diff --git a/include/wx/choicebk.h b/include/wx/choicebk.h index dadd5f4be7..4423d095f6 100644 --- a/include/wx/choicebk.h +++ b/include/wx/choicebk.h @@ -76,6 +76,9 @@ public: virtual bool DeleteAllPages(); + // returns the choice control + wxChoice* GetChoiceCtrl() const { return m_choice; } + protected: virtual wxWindow *DoRemovePage(size_t page); diff --git a/include/wx/generic/propdlg.h b/include/wx/generic/propdlg.h index aaa717cee4..a2d43c9c57 100644 --- a/include/wx/generic/propdlg.h +++ b/include/wx/generic/propdlg.h @@ -71,8 +71,6 @@ public: long style = wxDEFAULT_DIALOG_STYLE, const wxString& name = wxDialogNameStr); - void Init(); - //// Accessors // Set and get the notebook @@ -100,11 +98,18 @@ public: // Adds the book control to the inner sizer. virtual void AddBookCtrl(wxSizer* sizer); + // Set the focus + void OnActivate(wxActivateEvent& event); + +private: + void Init(); + protected: wxBookCtrlBase* m_bookCtrl; wxSizer* m_innerSizer; // sizer for extra space DECLARE_DYNAMIC_CLASS(wxPropertySheetDialog) + DECLARE_EVENT_TABLE() }; #endif // _WX_PROPDLG_H_ diff --git a/src/generic/propdlg.cpp b/src/generic/propdlg.cpp index f94ec74a30..ecbaf34ed3 100644 --- a/src/generic/propdlg.cpp +++ b/src/generic/propdlg.cpp @@ -39,13 +39,14 @@ IMPLEMENT_DYNAMIC_CLASS(wxPropertySheetDialog, wxDialog) +BEGIN_EVENT_TABLE(wxPropertySheetDialog, wxDialog) + EVT_ACTIVATE(wxPropertySheetDialog::OnActivate) +END_EVENT_TABLE() + bool wxPropertySheetDialog::Create(wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, const wxSize& sz, long style, const wxString& name) { -#if defined(__SMARTPHONE__) || defined(__POCKETPC__) - style = wxNO_BORDER; -#endif if (!wxDialog::Create(parent, id, title, pos, sz, style, name)) return false; @@ -80,6 +81,10 @@ void wxPropertySheetDialog::LayoutDialog() GetSizer()->Fit(this); Centre(wxBOTH); #endif +#if defined(__SMARTPHONE__) + if (m_bookCtrl) + m_bookCtrl->SetFocus(); +#endif } // Creates the buttons, if any @@ -123,3 +128,21 @@ void wxPropertySheetDialog::AddBookCtrl(wxSizer* sizer) #endif } +void wxPropertySheetDialog::OnActivate(wxActivateEvent& event) +{ +#if defined(__SMARTPHONE__) + // Attempt to focus the choice control: not yet working, but might + // be a step in the right direction. OnActivate overrides the default + // handler in toplevel.cpp that sets the focus for the first child of + // of the dialog (the choicebook). + if (event.GetActive()) + { + wxChoicebook* choiceBook = wxDynamicCast(GetBookCtrl(), wxChoicebook); + if (choiceBook) + choiceBook->SetFocus(); + } + else +#endif + event.Skip(); +} + -- 2.45.2