From c7382f913cc2d3ddcc782b876574c58865e7d842 Mon Sep 17 00:00:00 2001 From: Julian Smart Date: Sun, 29 Aug 2004 13:32:45 +0000 Subject: [PATCH] SetBackgroundStyle(wxBG_STYLE_CUSTOM) can now be used to optimize background erase on wxGTK (no-op on other platforms) git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@28954 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/gtk/window.h | 4 +++ include/wx/gtk1/window.h | 4 +++ src/gtk/window.cpp | 58 +++++++++++++++++++++++++++++++++++----- src/gtk1/window.cpp | 58 +++++++++++++++++++++++++++++++++++----- 4 files changed, 112 insertions(+), 12 deletions(-) diff --git a/include/wx/gtk/window.h b/include/wx/gtk/window.h index dfded278e5..607f344c21 100644 --- a/include/wx/gtk/window.h +++ b/include/wx/gtk/window.h @@ -80,6 +80,8 @@ public: virtual bool SetCursor( const wxCursor &cursor ); virtual bool SetFont( const wxFont &font ); + virtual bool SetBackgroundStyle(wxBackgroundStyle style) ; + virtual int GetCharHeight() const; virtual int GetCharWidth() const; virtual void GetTextExtent(const wxString& string, @@ -238,6 +240,8 @@ public: bool m_dirtyTabOrder:1; // tab order changed, GTK focus // chain needs update #endif + bool m_needsStyleChange:1; // May not be able to change + // background style until OnIdle // C++ has no virtual methods in the constrcutor of any class but we need // different methods of inserting a child window into a wxFrame, diff --git a/include/wx/gtk1/window.h b/include/wx/gtk1/window.h index dfded278e5..607f344c21 100644 --- a/include/wx/gtk1/window.h +++ b/include/wx/gtk1/window.h @@ -80,6 +80,8 @@ public: virtual bool SetCursor( const wxCursor &cursor ); virtual bool SetFont( const wxFont &font ); + virtual bool SetBackgroundStyle(wxBackgroundStyle style) ; + virtual int GetCharHeight() const; virtual int GetCharWidth() const; virtual void GetTextExtent(const wxString& string, @@ -238,6 +240,8 @@ public: bool m_dirtyTabOrder:1; // tab order changed, GTK focus // chain needs update #endif + bool m_needsStyleChange:1; // May not be able to change + // background style until OnIdle // C++ has no virtual methods in the constrcutor of any class but we need // different methods of inserting a child window into a wxFrame, diff --git a/src/gtk/window.cpp b/src/gtk/window.cpp index a461e3b7e8..380f121828 100644 --- a/src/gtk/window.cpp +++ b/src/gtk/window.cpp @@ -632,7 +632,7 @@ static void gtk_window_draw_callback( GtkWidget *widget, #ifndef __WXUNIVERSAL__ GtkPizza *pizza = GTK_PIZZA (widget); - if (win->GetThemeEnabled()) + if (win->GetThemeEnabled() && win->GetBackgroundStyle() != wxBG_STYLE_CUSTOM) { wxWindow *parent = win->GetParent(); while (parent && !parent->IsTopLevel()) @@ -2646,6 +2646,8 @@ void wxWindowGTK::Init() m_clipPaintRegion = FALSE; + m_needsStyleChange = false; + m_cursor = *wxSTANDARD_CURSOR; #ifdef __WXGTK20__ @@ -3119,6 +3121,13 @@ void wxWindowGTK::OnInternalIdle() if ( m_dirtyTabOrder ) RealizeTabOrder(); #endif + // Update style if the window was not yet realized + // and SetBackgroundStyle(wxBG_STYLE_CUSTOM) was called + if (m_needsStyleChange) + { + SetBackgroundStyle(GetBackgroundStyle()); + m_needsStyleChange = false; + } // Update invalidated regions. GtkUpdate(); @@ -3601,7 +3610,6 @@ void wxWindowGTK::GetTextExtent( const wxString& string, void wxWindowGTK::SetFocus() { wxCHECK_RET( m_widget != NULL, wxT("invalid window") ); - if ( m_hasFocus ) { // don't do anything if we already have focus @@ -3935,7 +3943,7 @@ void wxWindowGTK::GtkSendPaintEvents() // widget to draw on GtkPizza *pizza = GTK_PIZZA (m_wxwindow); - if (GetThemeEnabled()) + if (GetThemeEnabled() && GetBackgroundStyle() != wxBG_STYLE_CUSTOM) { // find ancestor from which to steal background wxWindow *parent = GetParent(); @@ -3989,7 +3997,7 @@ void wxWindowGTK::GtkSendPaintEvents() wxEraseEvent erase_event( GetId(), &dc ); erase_event.SetEventObject( this ); - if (!GetEventHandler()->ProcessEvent(erase_event)) + if (!GetEventHandler()->ProcessEvent(erase_event) && GetBackgroundStyle() != wxBG_STYLE_CUSTOM) { if (!g_eraseGC) { @@ -4114,8 +4122,9 @@ bool wxWindowGTK::SetBackgroundColour( const wxColour &colour ) } // apply style change (forceStyle=true so that new style is applied - // even if the bg colour changed from valid to wxNullColour): - ApplyWidgetStyle(true); + // even if the bg colour changed from valid to wxNullColour) + if (GetBackgroundStyle() != wxBG_STYLE_CUSTOM) + ApplyWidgetStyle(true); return true; } @@ -4242,6 +4251,43 @@ void wxWindowGTK::DoApplyWidgetStyle(GtkRcStyle *style) gtk_widget_modify_style(m_widget, style); } +bool wxWindowGTK::SetBackgroundStyle(wxBackgroundStyle style) +{ + wxWindowBase::SetBackgroundStyle(style); + + if (style == wxBG_STYLE_CUSTOM) + { + GdkWindow *window = (GdkWindow*) NULL; + if (m_wxwindow) + window = GTK_PIZZA(m_wxwindow)->bin_window; + else + window = GetConnectWidget()->window; + + if (window) + { + // Make sure GDK/X11 doesn't refresh the window + // automatically. + gdk_window_set_back_pixmap( window, None, False ); +#ifdef __X__ + Display* display = GDK_WINDOW_DISPLAY(window); + XFlush(display); +#endif + m_needsStyleChange = false; + } + else + // Do in OnIdle, because the window is not yet available + m_needsStyleChange = true; + + // Don't apply widget style, or we get a grey background + } + else + { + // apply style change (forceStyle=true so that new style is applied + // even if the bg colour changed from valid to wxNullColour): + ApplyWidgetStyle(true); + } + return true; +} //----------------------------------------------------------------------------- // Pop-up menu stuff diff --git a/src/gtk1/window.cpp b/src/gtk1/window.cpp index a461e3b7e8..380f121828 100644 --- a/src/gtk1/window.cpp +++ b/src/gtk1/window.cpp @@ -632,7 +632,7 @@ static void gtk_window_draw_callback( GtkWidget *widget, #ifndef __WXUNIVERSAL__ GtkPizza *pizza = GTK_PIZZA (widget); - if (win->GetThemeEnabled()) + if (win->GetThemeEnabled() && win->GetBackgroundStyle() != wxBG_STYLE_CUSTOM) { wxWindow *parent = win->GetParent(); while (parent && !parent->IsTopLevel()) @@ -2646,6 +2646,8 @@ void wxWindowGTK::Init() m_clipPaintRegion = FALSE; + m_needsStyleChange = false; + m_cursor = *wxSTANDARD_CURSOR; #ifdef __WXGTK20__ @@ -3119,6 +3121,13 @@ void wxWindowGTK::OnInternalIdle() if ( m_dirtyTabOrder ) RealizeTabOrder(); #endif + // Update style if the window was not yet realized + // and SetBackgroundStyle(wxBG_STYLE_CUSTOM) was called + if (m_needsStyleChange) + { + SetBackgroundStyle(GetBackgroundStyle()); + m_needsStyleChange = false; + } // Update invalidated regions. GtkUpdate(); @@ -3601,7 +3610,6 @@ void wxWindowGTK::GetTextExtent( const wxString& string, void wxWindowGTK::SetFocus() { wxCHECK_RET( m_widget != NULL, wxT("invalid window") ); - if ( m_hasFocus ) { // don't do anything if we already have focus @@ -3935,7 +3943,7 @@ void wxWindowGTK::GtkSendPaintEvents() // widget to draw on GtkPizza *pizza = GTK_PIZZA (m_wxwindow); - if (GetThemeEnabled()) + if (GetThemeEnabled() && GetBackgroundStyle() != wxBG_STYLE_CUSTOM) { // find ancestor from which to steal background wxWindow *parent = GetParent(); @@ -3989,7 +3997,7 @@ void wxWindowGTK::GtkSendPaintEvents() wxEraseEvent erase_event( GetId(), &dc ); erase_event.SetEventObject( this ); - if (!GetEventHandler()->ProcessEvent(erase_event)) + if (!GetEventHandler()->ProcessEvent(erase_event) && GetBackgroundStyle() != wxBG_STYLE_CUSTOM) { if (!g_eraseGC) { @@ -4114,8 +4122,9 @@ bool wxWindowGTK::SetBackgroundColour( const wxColour &colour ) } // apply style change (forceStyle=true so that new style is applied - // even if the bg colour changed from valid to wxNullColour): - ApplyWidgetStyle(true); + // even if the bg colour changed from valid to wxNullColour) + if (GetBackgroundStyle() != wxBG_STYLE_CUSTOM) + ApplyWidgetStyle(true); return true; } @@ -4242,6 +4251,43 @@ void wxWindowGTK::DoApplyWidgetStyle(GtkRcStyle *style) gtk_widget_modify_style(m_widget, style); } +bool wxWindowGTK::SetBackgroundStyle(wxBackgroundStyle style) +{ + wxWindowBase::SetBackgroundStyle(style); + + if (style == wxBG_STYLE_CUSTOM) + { + GdkWindow *window = (GdkWindow*) NULL; + if (m_wxwindow) + window = GTK_PIZZA(m_wxwindow)->bin_window; + else + window = GetConnectWidget()->window; + + if (window) + { + // Make sure GDK/X11 doesn't refresh the window + // automatically. + gdk_window_set_back_pixmap( window, None, False ); +#ifdef __X__ + Display* display = GDK_WINDOW_DISPLAY(window); + XFlush(display); +#endif + m_needsStyleChange = false; + } + else + // Do in OnIdle, because the window is not yet available + m_needsStyleChange = true; + + // Don't apply widget style, or we get a grey background + } + else + { + // apply style change (forceStyle=true so that new style is applied + // even if the bg colour changed from valid to wxNullColour): + ApplyWidgetStyle(true); + } + return true; +} //----------------------------------------------------------------------------- // Pop-up menu stuff -- 2.45.2