From c153cc08ebf622a5ec73be37e4368cdb3c00c24d Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 29 Oct 2006 18:09:36 +0000 Subject: [PATCH] don't set translation credits if they're empty (part of patch 1586730) git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42640 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/gtk/aboutdlg.cpp | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/gtk/aboutdlg.cpp b/src/gtk/aboutdlg.cpp index c5c7355563..b6d960990b 100644 --- a/src/gtk/aboutdlg.cpp +++ b/src/gtk/aboutdlg.cpp @@ -150,10 +150,20 @@ void wxAboutBox(const wxAboutDialogInfo& info) else // no translators explicitely specified { // maybe we have translator credits in the message catalog? - transCredits = _("translator-credits"); + wxString translator = _("translator-credits"); + + // gtk_about_dialog_set_translator_credits() is smart enough to + // detect if "translator-credits" is untranslated and hide the + // translators tab in that case, however it will still show the + // "credits" button, (at least GTK 2.10.6) even if there are no + // credits informations at all, so we still need to do the check + // ourselves + if ( translator != wxT("translator-credits") ) // untranslated! + transCredits = translator; } - gtk_about_dialog_set_translator_credits(dlg, GtkStr(transCredits)); + if ( !transCredits.empty() ) + gtk_about_dialog_set_translator_credits(dlg, GtkStr(transCredits)); g_signal_connect(dlg, "response", G_CALLBACK(wxGtkAboutDialogOnClose), NULL); -- 2.45.2