From b99891b0c8153704a9772ec8a60d548de86c531d Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Fri, 22 Jun 2007 18:09:03 +0000
Subject: [PATCH] suppress virtual function hiding warnings due to the
 existence of several DoLog() and DoLogString() overloads of which only one is
 overridden

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@46646 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---
 include/wx/generic/logg.h |  7 +++++++
 include/wx/log.h          | 26 ++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)

diff --git a/include/wx/generic/logg.h b/include/wx/generic/logg.h
index 33ba8d6c08..3030d3bd3b 100644
--- a/include/wx/generic/logg.h
+++ b/include/wx/generic/logg.h
@@ -32,6 +32,8 @@ protected:
     // implement sink function
     virtual void DoLogString(const wxString& szString, time_t t);
 
+    wxSUPPRESS_DOLOGSTRING_HIDE_WARNING()
+
 private:
     // the control we use
     wxTextCtrl *m_pTextCtrl;
@@ -59,6 +61,8 @@ public:
 protected:
     virtual void DoLog(wxLogLevel level, const wxString& szString, time_t t);
 
+    wxSUPPRESS_DOLOG_HIDE_WARNING()
+
     // empty everything
     void Clear();
 
@@ -115,6 +119,9 @@ protected:
     virtual void DoLog(wxLogLevel level, const wxString& szString, time_t t);
     virtual void DoLogString(const wxString& szString, time_t t);
 
+    wxSUPPRESS_DOLOG_HIDE_WARNING()
+    wxSUPPRESS_DOLOGSTRING_HIDE_WARNING()
+
 private:
     wxLogFrame *m_pLogFrame;      // the log frame
 
diff --git a/include/wx/log.h b/include/wx/log.h
index 4b4f745408..de2b9b817a 100644
--- a/include/wx/log.h
+++ b/include/wx/log.h
@@ -279,6 +279,23 @@ protected:
                              time_t WXUNUSED(t)) {}
     virtual void DoLogString(const wchar_t *WXUNUSED(szString),
                              time_t WXUNUSED(t)) {}
+#endif // WXWIN_COMPATIBILITY_2_8
+
+    // this macro should be used in the derived classes to avoid warnings about
+    // hiding the other DoLog() overloads when overriding DoLog(wxString) --
+    // but don't use it with MSVC which doesn't give this warning but does give
+    // warning when a deprecated function is overridden
+#if WXWIN_COMPATIBILITY_2_8 && !defined(__VISUALC__)
+    #define wxSUPPRESS_DOLOG_HIDE_WARNING()                                   \
+        virtual void DoLog(wxLogLevel, const char *, time_t) { }              \
+        virtual void DoLog(wxLogLevel, const wchar_t *, time_t) { }
+
+    #define wxSUPPRESS_DOLOGSTRING_HIDE_WARNING()                             \
+        virtual void DoLogString(const char *, time_t) { }                    \
+        virtual void DoLogString(const wchar_t *, time_t) { }
+#else
+    #define wxSUPPRESS_DOLOG_HIDE_WARNING()
+    #define wxSUPPRESS_DOLOGSTRING_HIDE_WARNING()
 #endif
 
     // log a line containing the number of times the previous message was
@@ -336,6 +353,9 @@ protected:
     virtual void DoLog(wxLogLevel level, const wxString& szString, time_t t);
     virtual void DoLogString(const wxString& szString, time_t t);
 
+    wxSUPPRESS_DOLOG_HIDE_WARNING()
+    wxSUPPRESS_DOLOGSTRING_HIDE_WARNING()
+
 private:
     wxString m_str;
 
@@ -354,6 +374,8 @@ protected:
     // implement sink function
     virtual void DoLogString(const wxString& szString, time_t t);
 
+    wxSUPPRESS_DOLOGSTRING_HIDE_WARNING()
+
     FILE *m_fp;
 
     DECLARE_NO_COPY_CLASS(wxLogStderr)
@@ -372,6 +394,8 @@ protected:
     // implement sink function
     virtual void DoLogString(const wxString& szString, time_t t);
 
+    wxSUPPRESS_DOLOGSTRING_HIDE_WARNING()
+
     // using ptr here to avoid including <iostream.h> from this file
     wxSTD ostream *m_ostr;
 };
@@ -446,6 +470,8 @@ protected:
     // pass the chain to the old logger if needed
     virtual void DoLog(wxLogLevel level, const wxString& szString, time_t t);
 
+    wxSUPPRESS_DOLOG_HIDE_WARNING()
+
 private:
     // the current log target
     wxLog *m_logNew;
-- 
2.45.2