From afcdd052c1b6d83ab70478e0894ab288f29f1b87 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Fri, 24 Nov 2006 09:25:49 +0000 Subject: [PATCH] Fixed bug in wxCalendarCtrl::HitTest() when clicking on month change arrows git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@43622 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- docs/changes.txt | 1 + src/generic/calctrl.cpp | 28 ++++++++++------------------ 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/docs/changes.txt b/docs/changes.txt index 64dad4cdde..5383882f42 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -96,6 +96,7 @@ All: - Fixed long standing bug in wxFileConfig groups renaming (Antti Koivisto). - New option wxFS_READ | wxFS_SEEKABLE for wxFileSystem::OpenFile() to return a stream that is seekable. +- Fixed bug in wxCalendarCtrl::HitTest() when clicking on month change arrows wxMSW: diff --git a/src/generic/calctrl.cpp b/src/generic/calctrl.cpp index 2fb1c41725..cd1593d7b1 100644 --- a/src/generic/calctrl.cpp +++ b/src/generic/calctrl.cpp @@ -1487,21 +1487,17 @@ wxCalendarHitTestResult wxCalendarCtrl::HitTest(const wxPoint& pos, wxDateTime::WeekDay *wd) { RecalcGeometry(); - // use the correct x-pos - wxCoord x0 = wxMax((GetSize().x - m_widthCol*7) /2, 0); - wxPoint pos_corr = pos; - pos_corr.x -= x0; - wxCoord y = pos_corr.y; + // the position where the calendar really begins + wxCoord x0 = wxMax((GetSize().x - m_widthCol*7)/2, 0); -/////////////////////////////////////////////////////////////////////////////////////////////////////// - if ( (GetWindowStyle() & wxCAL_SEQUENTIAL_MONTH_SELECTION) ) + if ( HasFlag(wxCAL_SEQUENTIAL_MONTH_SELECTION) ) { // Header: month // we need to find out if the hit is on left arrow, on month or on right arrow // left arrow? - if ( wxRegion(m_leftArrowRect).Contains(pos_corr) == wxInRegion ) + if ( m_leftArrowRect.Contains(pos) ) { if ( date ) { @@ -1518,7 +1514,7 @@ wxCalendarHitTestResult wxCalendarCtrl::HitTest(const wxPoint& pos, return wxCAL_HITTEST_DECMONTH; } - if ( wxRegion(m_rightArrowRect).Contains(pos_corr) == wxInRegion ) + if ( m_rightArrowRect.Contains(pos) ) { if ( date ) { @@ -1537,14 +1533,11 @@ wxCalendarHitTestResult wxCalendarCtrl::HitTest(const wxPoint& pos, } -/////////////////////////////////////////////////////////////////////////////////////////////////////// - // Header: Days - - int wday = pos_corr.x / m_widthCol; -// if ( y < m_heightRow ) - if ( y < (m_heightRow + m_rowOffset) ) + // header: week days + int wday = (pos.x - x0) / m_widthCol; + if ( pos.y < (m_heightRow + m_rowOffset) ) { - if ( y > m_rowOffset ) + if ( pos.y > m_rowOffset ) { if ( wd ) { @@ -1564,8 +1557,7 @@ wxCalendarHitTestResult wxCalendarCtrl::HitTest(const wxPoint& pos, } } -// int week = (y - m_heightRow) / m_heightRow; - int week = (y - (m_heightRow + m_rowOffset)) / m_heightRow; + int week = (pos.y - (m_heightRow + m_rowOffset)) / m_heightRow; if ( week >= 6 || wday >= 7 ) { return wxCAL_HITTEST_NOWHERE; -- 2.45.2