From af07be96ebf1887f5d93332d95e8ddd934a17198 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 26 Feb 2011 17:46:54 +0000 Subject: [PATCH] Don't use wxTE_PROCESS_ENTER in wxSpinCtrlGeneric. We don't need to catch Enter presses to generate spin control events as we do it anyhow when we lose focus. So simply remove the Enter handling code entirely (it could be used to generate wxEVT_COMMAND_TEXT_ENTER events but we don't generate them nor wxEVT_COMMAND_TEXT_UPDATED at all currently in the generic version). Closes #12980. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@67031 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/generic/spinctlg.h | 2 +- src/generic/spinctlg.cpp | 18 +++--------------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/include/wx/generic/spinctlg.h b/include/wx/generic/spinctlg.h index 2cc581c928..aa44dc989a 100644 --- a/include/wx/generic/spinctlg.h +++ b/include/wx/generic/spinctlg.h @@ -89,7 +89,7 @@ public: // forwarded events from children windows void OnSpinButton(wxSpinEvent& event); - void OnTextEnter(wxCommandEvent& event); + void OnTextLostFocus(); void OnTextChar(wxKeyEvent& event); // this window itself is used only as a container for its sub windows so it diff --git a/src/generic/spinctlg.cpp b/src/generic/spinctlg.cpp index 2628efefa6..796f89efb5 100644 --- a/src/generic/spinctlg.cpp +++ b/src/generic/spinctlg.cpp @@ -64,7 +64,7 @@ class wxSpinCtrlTextGeneric : public wxTextCtrl public: wxSpinCtrlTextGeneric(wxSpinCtrlGenericBase *spin, const wxString& value, long style=0) : wxTextCtrl(spin->GetParent(), wxID_ANY, value, wxDefaultPosition, wxDefaultSize, - ( style & wxALIGN_MASK ) | wxTE_PROCESS_ENTER) + style & wxALIGN_MASK) { m_spin = spin; @@ -81,12 +81,6 @@ public: m_spin = NULL; } - void OnTextEnter(wxCommandEvent& event) - { - if (m_spin) - m_spin->OnTextEnter(event); - } - void OnChar( wxKeyEvent &event ) { if (m_spin) @@ -96,10 +90,7 @@ public: void OnKillFocus(wxFocusEvent& event) { if (m_spin) - { - if ( m_spin->SyncSpinToText() ) - m_spin->DoSendEvent(); - } + m_spin->OnTextLostFocus(); event.Skip(); } @@ -111,8 +102,6 @@ private: }; BEGIN_EVENT_TABLE(wxSpinCtrlTextGeneric, wxTextCtrl) - EVT_TEXT_ENTER(wxID_ANY, wxSpinCtrlTextGeneric::OnTextEnter) - EVT_CHAR(wxSpinCtrlTextGeneric::OnChar) EVT_KILL_FOCUS(wxSpinCtrlTextGeneric::OnKillFocus) @@ -367,11 +356,10 @@ void wxSpinCtrlGenericBase::OnSpinButton(wxSpinEvent& event) DoSendEvent(); } -void wxSpinCtrlGenericBase::OnTextEnter(wxCommandEvent& event) +void wxSpinCtrlGenericBase::OnTextLostFocus() { SyncSpinToText(); DoSendEvent(); - event.Skip(); } void wxSpinCtrlGenericBase::OnTextChar(wxKeyEvent& event) -- 2.45.2