From a90bf709147ab0640d138ba7e34af721bfd717d2 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 25 Jul 2004 11:00:14 +0000 Subject: [PATCH] tided up the code a little (replaces part of patch 966312) git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@28450 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/unix/displayx11.cpp | 75 +++++++++++++++++++---------------------- 1 file changed, 35 insertions(+), 40 deletions(-) diff --git a/src/unix/displayx11.cpp b/src/unix/displayx11.cpp index a51285f3b8..4736e99523 100644 --- a/src/unix/displayx11.cpp +++ b/src/unix/displayx11.cpp @@ -164,7 +164,7 @@ wxString wxDisplay::GetName() const //free private data common to x (usually s3) servers #define wxClearXVM(vm) if(vm.privsize) XFree(vm.c_private) -//Correct res rate from GLFW, which probably has the perfect license :) +// Correct res rate from GLFW #define wxCRR2(v,dc) (int) (((1000.0f * (float) dc) /*PIXELS PER SECOND */) / ((float) v.htotal * v.vtotal /*PIXELS PER FRAME*/) + 0.5f) #define wxCRR(v) wxCRR2(v,v.dotclock) #define wxCVM2(v, dc) wxVideoMode(v.hdisplay, v.vdisplay, DefaultDepth((Display*)wxGetDisplay(), DefaultScreen((Display*)wxGetDisplay())), wxCRR2(v,dc)) @@ -216,53 +216,48 @@ wxVideoMode wxDisplay::GetCurrentMode() const bool wxDisplay::ChangeMode(const wxVideoMode& mode) { - //This gets kind of tricky AND complicated :) :\ :( :) + XF86VidModeModeInfo** ppXModes; //Enumerated Modes (Don't forget XFree() :)) + int nNumModes; //Number of modes enumerated.... + + if( !XF86VidModeGetAllModeLines((Display*)wxGetDisplay(), DefaultScreen((Display*)wxGetDisplay()), &nNumModes, &ppXModes) ) { - bool bRet = false; - //Some variables.. - XF86VidModeModeInfo** ppXModes; //Enumerated Modes (Don't forget XFree() :)) - int nNumModes; //Number of modes enumerated.... + wxLogSysError(_("Failed to change video mode")); + return false; + } - if(XF86VidModeGetAllModeLines((Display*)wxGetDisplay(), DefaultScreen((Display*)wxGetDisplay()), &nNumModes, &ppXModes) == TRUE) + bool bRet = false; + if (mode == wxDefaultVideoMode) + { + bRet = XF86VidModeSwitchToMode((Display*)wxGetDisplay(), DefaultScreen((Display*)wxGetDisplay()), + ppXModes[0]) == TRUE; + + for (int i = 0; i < nNumModes; ++i) { - if (mode == wxDefaultVideoMode) + wxClearXVM((*ppXModes[i])); + // XFree(ppXModes[i]); //supposed to free? + } + } + else + { + for (int i = 0; i < nNumModes; ++i) + { + if (!bRet && + ppXModes[i]->hdisplay == mode.w && + ppXModes[i]->vdisplay == mode.h && + wxCRR((*ppXModes[i])) == mode.refresh) { + //switch! bRet = XF86VidModeSwitchToMode((Display*)wxGetDisplay(), DefaultScreen((Display*)wxGetDisplay()), - ppXModes[0]) == TRUE; - - for (int i = 0; i < nNumModes; ++i) - { - wxClearXVM((*ppXModes[i])); - // XFree(ppXModes[i]); //supposed to free? - } - XFree(ppXModes); - - return bRet; + ppXModes[i]) == TRUE; } - for (int i = 0; i < nNumModes; ++i) - { - if (!bRet && - ppXModes[i]->hdisplay == mode.w && - ppXModes[i]->vdisplay == mode.h && - wxCRR((*ppXModes[i])) == mode.refresh) - { - //switch! - bRet = XF86VidModeSwitchToMode((Display*)wxGetDisplay(), DefaultScreen((Display*)wxGetDisplay()), - ppXModes[i]) == TRUE; - } - wxClearXVM((*ppXModes[i])); - // XFree(ppXModes[i]); //supposed to free? - } - XFree(ppXModes); - - return bRet; - } - else //OOPS! - { - wxLogSysError(_("Failed to change video mode")); - return false; + wxClearXVM((*ppXModes[i])); + // XFree(ppXModes[i]); //supposed to free? } } + + XFree(ppXModes); + + return bRet; } -- 2.45.2