From a4352768d7b37ea0ff686e2a089276d0ea985617 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Thu, 11 Jan 2001 14:58:19 +0000 Subject: [PATCH] applied (slightly modified) patch for loading large/small icons git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@9076 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/msw/gdiimage.cpp | 43 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/src/msw/gdiimage.cpp b/src/msw/gdiimage.cpp index 4123b7d4f6..63673882cc 100644 --- a/src/msw/gdiimage.cpp +++ b/src/msw/gdiimage.cpp @@ -401,7 +401,41 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, wxSize size; #ifdef __WIN32__ - HICON hicon = ::ExtractIcon(wxGetInstance(), name, 0 /* first */); + HICON hicon = NULL; + + // were we asked for a large icon? + if ( desiredWidth == ::GetSystemMetrics(SM_CXICON) && + desiredHeight == ::GetSystemMetrics(SM_CYICON) ) + { + // get the first large icon from file + if ( !::ExtractIconEx(name, 0, &hicon, NULL, 1) ) + { + // it is not an error, but it might still be useful to be informed + // about it optionally + wxLogTrace(_T("iconload"), + _T("No large icons found in the file '%s'."), + name.c_str()); + } + } + else if ( desiredWidth == ::GetSystemMetrics(SM_CXSMICON) && + desiredHeight == ::GetSystemMetrics(SM_CYSMICON) ) + { + // get the first small icon from file + if ( !::ExtractIconEx(name, 0, NULL, &hicon, 1) ) + { + wxLogTrace(_T("iconload"), + _T("No small icons found in the file '%s'."), + name.c_str()); + } + } + //else: not standard size, load below + + if ( !hicon ) + { + // take any (the first one) icon from the file by default + hicon = ::ExtractIcon(wxGetInstance(), name, 0 /* first */); + } + if ( !hicon ) { wxLogSysError(_T("Failed to load icon from the file '%s'"), @@ -420,9 +454,10 @@ bool wxICOFileHandler::LoadIcon(wxIcon *icon, if ( (desiredWidth != -1 && desiredWidth != size.x) || (desiredHeight != -1 && desiredHeight != size.y) ) { - wxLogDebug(_T("Returning FALSE from wxICOFileHandler::Load because of the size mismatch: actual (%d, %d), requested (%d, %d)"), - size.x, size.y, - desiredWidth, desiredHeight); + wxLogTrace(_T("iconload"), + _T("Returning FALSE from wxICOFileHandler::Load because of the size mismatch: actual (%d, %d), requested (%d, %d)"), + size.x, size.y, + desiredWidth, desiredHeight); ::DestroyIcon(hicon); -- 2.45.2