From a02b2a9d31b9ebc9cb13e0ea744169bc355e2ea0 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 4 Mar 2012 00:29:51 +0000 Subject: [PATCH] Don't set value unnecessarily in wxSpinCtrl::Create() in wxMSW. This is not only unnecessary but also results in an unexpected event (which could be avoided by using ChangeValue() but why bother calling it at all if we don't need to). Closes #13589. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@70800 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/msw/spinctrl.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/msw/spinctrl.cpp b/src/msw/spinctrl.cpp index 7d79dc76d9..7919453f85 100644 --- a/src/msw/spinctrl.cpp +++ b/src/msw/spinctrl.cpp @@ -394,14 +394,15 @@ bool wxSpinCtrl::Create(wxWindow *parent, // Set the range in the native control SetRange(min, max); - if ( !value.empty() ) + // If necessary, set the textual value. Don't do it if it's the same as the + // numeric value though. + if ( value != wxString::Format("%d", initial) ) { SetValue(value); m_oldValue = (int) wxAtol(value); } else { - SetValue(wxString::Format(wxT("%d"), initial)); m_oldValue = initial; } -- 2.45.2