From 9df97be2c166a4d2c13e80f6a12411f03c2df023 Mon Sep 17 00:00:00 2001 From: Steve Lamerton Date: Tue, 5 Jul 2011 15:33:42 +0000 Subject: [PATCH] Simplify backend enum naming, we do not need separate values for gtk and osx webkit backends. Simplify factory creation code. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/branches/SOC2011_WEBVIEW@68169 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/webview.h | 7 ++---- interface/wx/webview.h | 7 ++---- src/common/webview.cpp | 48 ++++++++++++++---------------------------- 3 files changed, 20 insertions(+), 42 deletions(-) diff --git a/include/wx/webview.h b/include/wx/webview.h index 368775a10b..fe010713fa 100644 --- a/include/wx/webview.h +++ b/include/wx/webview.h @@ -97,11 +97,8 @@ enum wxWebViewBackend * engine for the current platform*/ wxWEB_VIEW_BACKEND_DEFAULT, - /** The OSX-native WebKit web engine */ - wxWEB_VIEW_BACKEND_OSX_WEBKIT, - - /** The GTK port of the WebKit engine */ - wxWEB_VIEW_BACKEND_GTK_WEBKIT, + /** The WebKit web engine */ + wxWEB_VIEW_BACKEND_WEBKIT, /** Use Microsoft Internet Explorer as web engine */ wxWEB_VIEW_BACKEND_IE diff --git a/interface/wx/webview.h b/interface/wx/webview.h index 455ce7db72..2e5e3dbdbb 100644 --- a/interface/wx/webview.h +++ b/interface/wx/webview.h @@ -79,11 +79,8 @@ enum wxWebViewBackend * engine for the current platform*/ wxWEB_VIEW_BACKEND_DEFAULT, - /** The OSX-native WebKit web engine */ - wxWEB_VIEW_BACKEND_OSX_WEBKIT, - - /** The GTK port of the WebKit engine */ - wxWEB_VIEW_BACKEND_GTK_WEBKIT, + /** The WebKit web engine */ + wxWEB_VIEW_BACKEND_WEBKIT, /** Use Microsoft Internet Explorer as web engine */ wxWEB_VIEW_BACKEND_IE diff --git a/src/common/webview.cpp b/src/common/webview.cpp index 1766ef0366..8c69bb9275 100644 --- a/src/common/webview.cpp +++ b/src/common/webview.cpp @@ -42,28 +42,21 @@ wxWebView* wxWebView::New(wxWebViewBackend backend) { switch (backend) { - #if defined(wxUSE_WEBVIEW_WEBKIT) && defined(__WXOSX__) - case wxWEB_VIEW_BACKEND_OSX_WEBKIT: - return new wxWebViewWebKit(); - #endif - - #if defined(wxUSE_WEBVIEW_WEBKIT) && defined(__WXGTK__) - case wxWEB_VIEW_BACKEND_GTK_WEBKIT: - return new wxWebViewWebKit(); + #if defined(wxUSE_WEBVIEW_WEBKIT) && \ + (defined(__WXGTK__) || defined(__WXOSX__)) + case wxWEB_VIEW_BACKEND_WEBKIT: + return new wxWebViewWebKit(); #endif #if wxUSE_WEBVIEW_IE - case wxWEB_VIEW_BACKEND_IE: - return new wxWebViewIE(); + case wxWEB_VIEW_BACKEND_IE: + return new wxWebViewIE(); #endif case wxWEB_VIEW_BACKEND_DEFAULT: - #if defined(wxUSE_WEBVIEW_WEBKIT) && defined(__WXOSX__) - return new wxWebViewWebKit(); - #endif - - #if defined(wxUSE_WEBVIEW_WEBKIT) && defined(__WXGTK__) + #if defined(wxUSE_WEBVIEW_WEBKIT) && \ + (defined(__WXGTK__) || defined(__WXOSX__)) return new wxWebViewWebKit(); #endif @@ -89,30 +82,21 @@ wxWebView* wxWebView::New(wxWindow* parent, { switch (backend) { - #if defined(wxUSE_WEBVIEW_WEBKIT) && defined(__WXOSX__) - case wxWEB_VIEW_BACKEND_OSX_WEBKIT: - return new wxWebViewWebKit(parent, id, url, pos, size, style, - name); - #endif - - #if defined(wxUSE_WEBVIEW_WEBKIT) && defined(__WXGTK__) - case wxWEB_VIEW_BACKEND_GTK_WEBKIT: - return new wxWebViewWebKit(parent, id, url, pos, size, style, - name); + #if defined(wxUSE_WEBVIEW_WEBKIT) && \ + (defined(__WXGTK__) || defined(__WXOSX__)) + case wxWEB_VIEW_BACKEND_WEBKIT: + return new wxWebViewWebKit(parent, id, url, pos, size, style, name); #endif #if wxUSE_WEBVIEW_IE - case wxWEB_VIEW_BACKEND_IE: - return new wxWebViewIE(parent, id, url, pos, size, style, name); + case wxWEB_VIEW_BACKEND_IE: + return new wxWebViewIE(parent, id, url, pos, size, style, name); #endif case wxWEB_VIEW_BACKEND_DEFAULT: - #if defined(wxUSE_WEBVIEW_WEBKIT) && defined(__WXOSX__) - return new wxWebViewWebKit(parent, id, url, pos, size, style, name); - #endif - - #if defined(wxUSE_WEBVIEW_WEBKIT) && defined(__WXGTK__) + #if defined(wxUSE_WEBVIEW_WEBKIT) && \ + (defined(__WXGTK__) || defined(__WXOSX__)) return new wxWebViewWebKit(parent, id, url, pos, size, style, name); #endif -- 2.45.2