From 87a3ebe978499aea7a64adcfc440191f257cf265 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 10 Oct 2005 18:22:47 +0000 Subject: [PATCH] added GtkUpdateScrollbar; folded some code duplicated for horz/vert orientations in a single branch git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@35874 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/gtk/window.h | 4 +++ include/wx/gtk1/window.h | 4 +++ src/gtk/window.cpp | 63 +++++++++++++++------------------------- src/gtk1/window.cpp | 63 +++++++++++++++------------------------- 4 files changed, 54 insertions(+), 80 deletions(-) diff --git a/include/wx/gtk/window.h b/include/wx/gtk/window.h index 0f47a27518..46475e3ea2 100644 --- a/include/wx/gtk/window.h +++ b/include/wx/gtk/window.h @@ -173,6 +173,10 @@ public: virtual void ApplyToolTip( GtkTooltips *tips, const wxChar *tip ); #endif // wxUSE_TOOLTIPS + // Call after modifing the value of m_hAdjust or m_vAdjust to bring the + // scrolbar in sync (this does not generate any wx events) + void GtkUpdateScrollbar(int orient); + // Called from GTK signales handlers. it indicates that // the layouting functions have to be called later on // (i.e. in idle time, implemented in OnInternalIdle() ). diff --git a/include/wx/gtk1/window.h b/include/wx/gtk1/window.h index 0f47a27518..46475e3ea2 100644 --- a/include/wx/gtk1/window.h +++ b/include/wx/gtk1/window.h @@ -173,6 +173,10 @@ public: virtual void ApplyToolTip( GtkTooltips *tips, const wxChar *tip ); #endif // wxUSE_TOOLTIPS + // Call after modifing the value of m_hAdjust or m_vAdjust to bring the + // scrolbar in sync (this does not generate any wx events) + void GtkUpdateScrollbar(int orient); + // Called from GTK signales handlers. it indicates that // the layouting functions have to be called later on // (i.e. in idle time, implemented in OnInternalIdle() ). diff --git a/src/gtk/window.cpp b/src/gtk/window.cpp index 7bd13fae8e..826fdd3c31 100644 --- a/src/gtk/window.cpp +++ b/src/gtk/window.cpp @@ -4705,55 +4705,38 @@ void wxWindowGTK::SetScrollbar( int orient, int pos, int thumbVisible, gtk_signal_emit_by_name( GTK_OBJECT(m_vAdjust), "changed" ); } +void wxWindowGTK::GtkUpdateScrollbar(int orient) +{ + GtkAdjustment *adj = orient == wxHORIZONTAL ? m_hAdjust : m_vAdjust; + GtkSignalFunc fn = orient == wxHORIZONTAL + ? (GtkSignalFunc)gtk_window_hscroll_callback + : (GtkSignalFunc)gtk_window_vscroll_callback; + + gtk_signal_disconnect_by_func(GTK_OBJECT(adj), fn, (gpointer)this); + gtk_signal_emit_by_name(GTK_OBJECT(adj), "value_changed"); + gtk_signal_connect(GTK_OBJECT(adj), "value_changed", fn, (gpointer)this); +} + void wxWindowGTK::SetScrollPos( int orient, int pos, bool WXUNUSED(refresh) ) { wxCHECK_RET( m_widget != NULL, wxT("invalid window") ); - wxCHECK_RET( m_wxwindow != NULL, wxT("window needs client area for scrolling") ); - if (orient == wxHORIZONTAL) - { - float fpos = (float)pos; - if (fpos > m_hAdjust->upper - m_hAdjust->page_size) fpos = m_hAdjust->upper - m_hAdjust->page_size; - if (fpos < 0.0) fpos = 0.0; - m_oldHorizontalPos = fpos; + GtkAdjustment *adj = orient == wxHORIZONTAL ? m_hAdjust : m_vAdjust; - if (fabs(fpos-m_hAdjust->value) < 0.2) return; - m_hAdjust->value = fpos; - } - else - { - float fpos = (float)pos; - if (fpos > m_vAdjust->upper - m_vAdjust->page_size) fpos = m_vAdjust->upper - m_vAdjust->page_size; - if (fpos < 0.0) fpos = 0.0; - m_oldVerticalPos = fpos; + float fpos = (float)pos; + if (fpos > adj->upper - adj->page_size) + fpos = adj->upper - adj->page_size; + if (fpos < 0.0) + fpos = 0.0; + *(orient == wxHORIZONTAL ? &m_oldHorizontalPos : &m_oldVerticalPos) = fpos; - if (fabs(fpos-m_vAdjust->value) < 0.2) return; - m_vAdjust->value = fpos; - } + if (fabs(fpos-adj->value) < 0.2) + return; + adj->value = fpos; - if (m_wxwindow->window) + if ( m_wxwindow->window ) { - if (orient == wxHORIZONTAL) - { - gtk_signal_disconnect_by_func( GTK_OBJECT(m_hAdjust), - (GtkSignalFunc) gtk_window_hscroll_callback, (gpointer) this ); - - gtk_signal_emit_by_name( GTK_OBJECT(m_hAdjust), "value_changed" ); - - gtk_signal_connect( GTK_OBJECT(m_hAdjust), "value_changed", - (GtkSignalFunc) gtk_window_hscroll_callback, (gpointer) this ); - } - else - { - gtk_signal_disconnect_by_func( GTK_OBJECT(m_vAdjust), - (GtkSignalFunc) gtk_window_vscroll_callback, (gpointer) this ); - - gtk_signal_emit_by_name( GTK_OBJECT(m_vAdjust), "value_changed" ); - - gtk_signal_connect( GTK_OBJECT(m_vAdjust), "value_changed", - (GtkSignalFunc) gtk_window_vscroll_callback, (gpointer) this ); - } } } diff --git a/src/gtk1/window.cpp b/src/gtk1/window.cpp index 7bd13fae8e..826fdd3c31 100644 --- a/src/gtk1/window.cpp +++ b/src/gtk1/window.cpp @@ -4705,55 +4705,38 @@ void wxWindowGTK::SetScrollbar( int orient, int pos, int thumbVisible, gtk_signal_emit_by_name( GTK_OBJECT(m_vAdjust), "changed" ); } +void wxWindowGTK::GtkUpdateScrollbar(int orient) +{ + GtkAdjustment *adj = orient == wxHORIZONTAL ? m_hAdjust : m_vAdjust; + GtkSignalFunc fn = orient == wxHORIZONTAL + ? (GtkSignalFunc)gtk_window_hscroll_callback + : (GtkSignalFunc)gtk_window_vscroll_callback; + + gtk_signal_disconnect_by_func(GTK_OBJECT(adj), fn, (gpointer)this); + gtk_signal_emit_by_name(GTK_OBJECT(adj), "value_changed"); + gtk_signal_connect(GTK_OBJECT(adj), "value_changed", fn, (gpointer)this); +} + void wxWindowGTK::SetScrollPos( int orient, int pos, bool WXUNUSED(refresh) ) { wxCHECK_RET( m_widget != NULL, wxT("invalid window") ); - wxCHECK_RET( m_wxwindow != NULL, wxT("window needs client area for scrolling") ); - if (orient == wxHORIZONTAL) - { - float fpos = (float)pos; - if (fpos > m_hAdjust->upper - m_hAdjust->page_size) fpos = m_hAdjust->upper - m_hAdjust->page_size; - if (fpos < 0.0) fpos = 0.0; - m_oldHorizontalPos = fpos; + GtkAdjustment *adj = orient == wxHORIZONTAL ? m_hAdjust : m_vAdjust; - if (fabs(fpos-m_hAdjust->value) < 0.2) return; - m_hAdjust->value = fpos; - } - else - { - float fpos = (float)pos; - if (fpos > m_vAdjust->upper - m_vAdjust->page_size) fpos = m_vAdjust->upper - m_vAdjust->page_size; - if (fpos < 0.0) fpos = 0.0; - m_oldVerticalPos = fpos; + float fpos = (float)pos; + if (fpos > adj->upper - adj->page_size) + fpos = adj->upper - adj->page_size; + if (fpos < 0.0) + fpos = 0.0; + *(orient == wxHORIZONTAL ? &m_oldHorizontalPos : &m_oldVerticalPos) = fpos; - if (fabs(fpos-m_vAdjust->value) < 0.2) return; - m_vAdjust->value = fpos; - } + if (fabs(fpos-adj->value) < 0.2) + return; + adj->value = fpos; - if (m_wxwindow->window) + if ( m_wxwindow->window ) { - if (orient == wxHORIZONTAL) - { - gtk_signal_disconnect_by_func( GTK_OBJECT(m_hAdjust), - (GtkSignalFunc) gtk_window_hscroll_callback, (gpointer) this ); - - gtk_signal_emit_by_name( GTK_OBJECT(m_hAdjust), "value_changed" ); - - gtk_signal_connect( GTK_OBJECT(m_hAdjust), "value_changed", - (GtkSignalFunc) gtk_window_hscroll_callback, (gpointer) this ); - } - else - { - gtk_signal_disconnect_by_func( GTK_OBJECT(m_vAdjust), - (GtkSignalFunc) gtk_window_vscroll_callback, (gpointer) this ); - - gtk_signal_emit_by_name( GTK_OBJECT(m_vAdjust), "value_changed" ); - - gtk_signal_connect( GTK_OBJECT(m_vAdjust), "value_changed", - (GtkSignalFunc) gtk_window_vscroll_callback, (gpointer) this ); - } } } -- 2.47.2