From 7fe5c04d6af25695488d1c6342f3b4fd4de515e5 Mon Sep 17 00:00:00 2001 From: Jaakko Salli Date: Thu, 25 Feb 2010 14:04:25 +0000 Subject: [PATCH] Fixed property Hide command git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63556 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- samples/propgrid/propgrid.cpp | 28 ++++------------------------ samples/propgrid/propgrid.h | 2 +- 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/samples/propgrid/propgrid.cpp b/samples/propgrid/propgrid.cpp index 37bcde4bd8..0122b230d2 100644 --- a/samples/propgrid/propgrid.cpp +++ b/samples/propgrid/propgrid.cpp @@ -750,7 +750,7 @@ BEGIN_EVENT_TABLE(FormMain, wxFrame) EVT_MENU( ID_DELETEALL, FormMain::OnClearClick ) EVT_MENU( ID_ENABLE, FormMain::OnEnableDisable ) EVT_MENU( ID_SETREADONLY, FormMain::OnSetReadOnly ) - EVT_MENU( ID_HIDE, FormMain::OnHideShow ) + EVT_MENU( ID_HIDE, FormMain::OnHide ) EVT_MENU( ID_ITERATE1, FormMain::OnIterate1Click ) EVT_MENU( ID_ITERATE2, FormMain::OnIterate2Click ) @@ -2289,7 +2289,7 @@ FormMain::FormMain(const wxString& title, const wxPoint& pos, const wxSize& size m_itemEnable = menuTools1->Append(ID_ENABLE, wxT("Enable"), wxT("Toggles item's enabled state.") ); m_itemEnable->Enable( FALSE ); - menuTools1->Append(ID_HIDE, wxT("Hide"), wxT("Shows or hides a property") ); + menuTools1->Append(ID_HIDE, "Hide", "Hides a property" ); menuTools1->Append(ID_SETREADONLY, "Set as Read-Only", "Set property as read-only" ); @@ -2752,7 +2752,7 @@ void FormMain::OnSetReadOnly( wxCommandEvent& WXUNUSED(event) ) // ----------------------------------------------------------------------- -void FormMain::OnHideShow( wxCommandEvent& WXUNUSED(event) ) +void FormMain::OnHide( wxCommandEvent& WXUNUSED(event) ) { wxPGProperty* id = m_pPropGridManager->GetGrid()->GetSelection(); if ( !id ) @@ -2761,27 +2761,7 @@ void FormMain::OnHideShow( wxCommandEvent& WXUNUSED(event) ) return; } - if ( m_pPropGridManager->IsPropertyShown( id ) ) - { - m_pPropGridManager->HideProperty( id, true ); - m_itemEnable->SetItemLabel( wxT("Show") ); - } - else - { - m_pPropGridManager->HideProperty( id, false ); - m_itemEnable->SetItemLabel( wxT("Hide") ); - } - - wxPropertyGridPage* curPage = m_pPropGridManager->GetCurrentPage(); - - // Check for bottomY precalculation validity - unsigned int byPre = curPage->GetVirtualHeight(); - unsigned int byAct = curPage->GetActualVirtualHeight(); - - if ( byPre != byAct ) - { - wxLogDebug(wxT("VirtualHeight is %u, should be %u"), byPre, byAct); - } + m_pPropGridManager->HideProperty( id, true ); } // ----------------------------------------------------------------------- diff --git a/samples/propgrid/propgrid.h b/samples/propgrid/propgrid.h index 3ffb11a7c6..fb051d3978 100644 --- a/samples/propgrid/propgrid.h +++ b/samples/propgrid/propgrid.h @@ -186,7 +186,7 @@ public: void OnEnableDisable( wxCommandEvent& event ); void OnSetReadOnly( wxCommandEvent& event ); - void OnHideShow( wxCommandEvent& event ); + void OnHide( wxCommandEvent& event ); void OnSetBackgroundColour( wxCommandEvent& event ); void OnClearModifyStatusClick( wxCommandEvent& event ); void OnFreezeClick( wxCommandEvent& event ); -- 2.45.2