From 784d24084800d506ce740e58007152a334780c71 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Wed, 26 Apr 2006 18:00:52 +0000 Subject: [PATCH] fixed unused param warning and code cleanup/simplification in DrawItemSelectionRect() git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@38928 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/generic/renderg.cpp | 56 +++++++++++++++-------------------------- 1 file changed, 20 insertions(+), 36 deletions(-) diff --git a/src/generic/renderg.cpp b/src/generic/renderg.cpp index 2c07be9d82..217cbbf19d 100644 --- a/src/generic/renderg.cpp +++ b/src/generic/renderg.cpp @@ -92,7 +92,7 @@ public: wxDC& dc, const wxRect& rect, int flags = 0); - + virtual wxSplitterRenderParams GetSplitterParams(const wxWindow *win); virtual wxRendererVersion GetVersion() const @@ -401,7 +401,7 @@ wxRendererGeneric::DrawDropArrow(wxWindow *win, dc.DrawPolygon(WXSIZEOF(pt), pt, rect.x, rect.y); } -void +void wxRendererGeneric::DrawCheckButton(wxWindow *WXUNUSED(win), wxDC& dc, const wxRect& rect, @@ -433,49 +433,33 @@ wxRendererGeneric::DrawPushButton(wxWindow *win, dc.DrawRectangle(rect); } -void -wxRendererGeneric::DrawItemSelectionRect(wxWindow *win, - wxDC& dc, - const wxRect& rect, - int flags ) +void +wxRendererGeneric::DrawItemSelectionRect(wxWindow * WXUNUSED(win), + wxDC& dc, + const wxRect& rect, + int flags) { - if (flags & wxCONTROL_SELECTED) + wxBrush brush; + if ( flags & wxCONTROL_SELECTED ) { - if (flags & wxCONTROL_FOCUSED) + if ( flags & wxCONTROL_FOCUSED ) { - wxBrush brush( - wxSystemSettings::GetColour - ( - wxSYS_COLOUR_HIGHLIGHT - ), - wxSOLID - ); - dc.SetBrush( brush ); + brush = wxBrush(wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHT)); } - else + else // !focused { - wxBrush brush( - wxSystemSettings::GetColour - ( - wxSYS_COLOUR_BTNSHADOW - ), - wxSOLID - ); - dc.SetBrush( brush ); + brush = wxBrush(wxSystemSettings::GetColour(wxSYS_COLOUR_BTNSHADOW)); } } - else + else // !selected { - dc.SetBrush( *wxTRANSPARENT_BRUSH ); + brush = *wxTRANSPARENT_BRUSH; } - - - if (flags & wxCONTROL_CURRENT) - dc.SetPen( *wxBLACK_PEN ); - else - dc.SetPen( *wxTRANSPARENT_PEN ); - - dc.DrawRectangle( rect ); + + dc.SetBrush(brush); + dc.SetPen(flags & wxCONTROL_CURRENT ? *wxBLACK_PEN : *wxTRANSPARENT_PEN); + + dc.DrawRectangle( rect ); } -- 2.45.2