From 72e430cd9754a68932bf907d282120f91cb0a040 Mon Sep 17 00:00:00 2001 From: Kevin Hock Date: Tue, 18 Jan 2005 15:17:05 +0000 Subject: [PATCH] For efficiency reasons, text controls no longer set the string for each text updated event, but rather query for the string value only when GetString is called from an event handler git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@31459 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/gtk/textctrl.cpp | 1 - src/gtk1/textctrl.cpp | 1 - src/mac/carbon/textctrl.cpp | 3 --- src/mac/classic/textctrl.cpp | 3 --- src/msw/textctrl.cpp | 1 - src/os2/textctrl.cpp | 1 - src/univ/textctrl.cpp | 1 - 7 files changed, 11 deletions(-) diff --git a/src/gtk/textctrl.cpp b/src/gtk/textctrl.cpp index a970bf7dd5..230e7d6646 100644 --- a/src/gtk/textctrl.cpp +++ b/src/gtk/textctrl.cpp @@ -202,7 +202,6 @@ gtk_text_changed_callback( GtkWidget *widget, wxTextCtrl *win ) wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, win->GetId() ); event.SetEventObject( win ); - event.SetString( win->GetValue() ); win->GetEventHandler()->ProcessEvent( event ); } diff --git a/src/gtk1/textctrl.cpp b/src/gtk1/textctrl.cpp index a970bf7dd5..230e7d6646 100644 --- a/src/gtk1/textctrl.cpp +++ b/src/gtk1/textctrl.cpp @@ -202,7 +202,6 @@ gtk_text_changed_callback( GtkWidget *widget, wxTextCtrl *win ) wxCommandEvent event( wxEVT_COMMAND_TEXT_UPDATED, win->GetId() ); event.SetEventObject( win ); - event.SetString( win->GetValue() ); win->GetEventHandler()->ProcessEvent( event ); } diff --git a/src/mac/carbon/textctrl.cpp b/src/mac/carbon/textctrl.cpp index d372d0a3b2..7cc3dd0fae 100644 --- a/src/mac/carbon/textctrl.cpp +++ b/src/mac/carbon/textctrl.cpp @@ -484,7 +484,6 @@ void wxTextCtrl::Cut() GetPeer()->Cut() ; wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, m_windowId); - event.SetString( GetValue() ) ; event.SetEventObject( this ); GetEventHandler()->ProcessEvent(event); } @@ -498,7 +497,6 @@ void wxTextCtrl::Paste() // eventually we should add setting the default style again wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, m_windowId); - event.SetString( GetValue() ) ; event.SetEventObject( this ); GetEventHandler()->ProcessEvent(event); } @@ -907,7 +905,6 @@ void wxTextCtrl::OnChar(wxKeyEvent& event) key == WXK_BACK) { wxCommandEvent event1(wxEVT_COMMAND_TEXT_UPDATED, m_windowId); - event1.SetString( GetValue() ) ; event1.SetEventObject( this ); wxPostEvent(GetEventHandler(),event1); } diff --git a/src/mac/classic/textctrl.cpp b/src/mac/classic/textctrl.cpp index 9fa64095ac..93123e9740 100644 --- a/src/mac/classic/textctrl.cpp +++ b/src/mac/classic/textctrl.cpp @@ -1039,7 +1039,6 @@ void wxTextCtrl::Cut() TXNConvertToPublicScrap(); } wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, m_windowId); - event.SetString( GetValue() ) ; event.SetEventObject( this ); GetEventHandler()->ProcessEvent(event); } @@ -1062,7 +1061,6 @@ void wxTextCtrl::Paste() SetStyle( kTXNUseCurrentSelection , kTXNUseCurrentSelection , GetDefaultStyle() ) ; } wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, m_windowId); - event.SetString( GetValue() ) ; event.SetEventObject( this ); GetEventHandler()->ProcessEvent(event); } @@ -1704,7 +1702,6 @@ void wxTextCtrl::OnChar(wxKeyEvent& event) key == WXK_BACK) { wxCommandEvent event1(wxEVT_COMMAND_TEXT_UPDATED, m_windowId); - event1.SetString( GetValue() ) ; event1.SetEventObject( this ); wxPostEvent(GetEventHandler(),event1); } diff --git a/src/msw/textctrl.cpp b/src/msw/textctrl.cpp index ef70b6f9e3..4a2c859fe7 100644 --- a/src/msw/textctrl.cpp +++ b/src/msw/textctrl.cpp @@ -1836,7 +1836,6 @@ bool wxTextCtrl::SendUpdateEvent() wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, GetId()); InitCommandEvent(event); - event.SetString(GetValue()); return ProcessCommand(event); } diff --git a/src/os2/textctrl.cpp b/src/os2/textctrl.cpp index e4b53da391..a1edc95104 100644 --- a/src/os2/textctrl.cpp +++ b/src/os2/textctrl.cpp @@ -1103,7 +1103,6 @@ bool wxTextCtrl::OS2Command( ); InitCommandEvent(vEvent); - vEvent.SetString((char*)GetValue().c_str()); ProcessCommand(vEvent); } break; diff --git a/src/univ/textctrl.cpp b/src/univ/textctrl.cpp index 167cf32f27..a49704f65f 100644 --- a/src/univ/textctrl.cpp +++ b/src/univ/textctrl.cpp @@ -4680,7 +4680,6 @@ bool wxTextCtrl::PerformAction(const wxControlAction& actionOrig, wxCommandEvent event(wxEVT_COMMAND_TEXT_UPDATED, GetId()); InitCommandEvent(event); - event.SetString(GetValue()); GetEventHandler()->ProcessEvent(event); // as the text changed... -- 2.45.2