From 6efda5fda46dd06598412e3138bc1950c975bd36 Mon Sep 17 00:00:00 2001 From: Paul Cornett Date: Wed, 6 May 2009 15:51:09 +0000 Subject: [PATCH] fix off-by-one size of wxCheckListBox item draw rect git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@60530 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/msw/listbox.cpp | 5 +---- src/msw/ownerdrw.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/msw/listbox.cpp b/src/msw/listbox.cpp index c732b395ac..3e6b8a7612 100644 --- a/src/msw/listbox.cpp +++ b/src/msw/listbox.cpp @@ -740,11 +740,8 @@ bool wxListBox::MSWOnDraw(WXDRAWITEMSTRUCT *item) wxListBoxItem *pItem = (wxListBoxItem *)m_aItems[pStruct->itemID]; wxDCTemp dc((WXHDC)pStruct->hDC); - wxPoint pt1(pStruct->rcItem.left, pStruct->rcItem.top); - wxPoint pt2(pStruct->rcItem.right, pStruct->rcItem.bottom); - wxRect rect(pt1, pt2); - return pItem->OnDrawItem(dc, rect, + return pItem->OnDrawItem(dc, wxRectFromRECT(pStruct->rcItem), (wxOwnerDrawn::wxODAction)pStruct->itemAction, (wxOwnerDrawn::wxODStatus)pStruct->itemState); } diff --git a/src/msw/ownerdrw.cpp b/src/msw/ownerdrw.cpp index 8cb3995978..c1dbd95207 100644 --- a/src/msw/ownerdrw.cpp +++ b/src/msw/ownerdrw.cpp @@ -379,8 +379,8 @@ bool wxOwnerDrawn::OnDrawItem(wxDC& dc, AutoHBRUSH hbr(colBack); SelectInHDC selBrush(hdc, hbr); - RECT rectFill = { rc.GetLeft(), rc.GetTop(), - rc.GetRight() + 1, rc.GetBottom() + 1 }; + RECT rectFill; + wxCopyRectToRECT(rc, rectFill); if ( (st & wxODSelected) && m_bmpChecked.Ok() && draw_bitmap_edge ) { @@ -418,7 +418,7 @@ bool wxOwnerDrawn::OnDrawItem(wxDC& dc, (LPARAM)strMenuText.wx_str(), strMenuText.length(), xText, - rc.y + (rc.GetHeight() - sizeRect.cy + 1)/2, // centre vertically + rc.y + (rc.height - sizeRect.cy) / 2, // centre vertically rc.GetWidth() - margin, sizeRect.cy, flags @@ -436,7 +436,7 @@ bool wxOwnerDrawn::OnDrawItem(wxDC& dc, ::DrawState(hdc, NULL, NULL, (LPARAM)m_strAccel.wx_str(), m_strAccel.length(), - rc.GetWidth()-16-accel_width, rc.y+(int) ((rc.GetHeight()-sizeRect.cy)/2.0), + rc.width - 16 - accel_width, rc.y + (rc.height - sizeRect.cy) / 2, 0, 0, DST_TEXT | (((st & wxODDisabled) && !(st & wxODSelected)) ? DSS_DISABLED : 0)); -- 2.47.2