From 6115b1b5d90ffac0ead7082fb8106f44d45783e6 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 15 Dec 2008 09:49:57 +0000 Subject: [PATCH 1/1] don't leave nrows/ncols uninitialized in wxGridSizer::CalcRowsCols() git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@57351 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/common/sizer.cpp | 45 +++++++++++++++++++++----------------------- 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/src/common/sizer.cpp b/src/common/sizer.cpp index 65d2f3d9cb..af8275b478 100644 --- a/src/common/sizer.cpp +++ b/src/common/sizer.cpp @@ -1325,32 +1325,29 @@ wxGridSizer::wxGridSizer( int cols, int vgap, int hgap ) int wxGridSizer::CalcRowsCols(int& nrows, int& ncols) const { const int nitems = m_children.GetCount(); - if ( nitems ) + if ( m_cols && m_rows ) { - if ( m_cols && m_rows ) - { - // if both rows and columns are specified by user, use the provided - // values even if we don't have enough items - ncols = m_cols; - nrows = m_rows; - } - else if ( m_cols ) - { - ncols = m_cols; - nrows = (nitems + m_cols - 1) / m_cols; - } - else if ( m_rows ) - { - ncols = (nitems + m_rows - 1) / m_rows; - nrows = m_rows; - } - else // 0 columns, 0 rows? - { - wxFAIL_MSG( _T("grid sizer must have either rows or columns fixed") ); + // if both rows and columns are specified by user, use the provided + // values even if we don't have enough items + ncols = m_cols; + nrows = m_rows; + } + else if ( m_cols ) + { + ncols = m_cols; + nrows = (nitems + m_cols - 1) / m_cols; + } + else if ( m_rows ) + { + ncols = (nitems + m_rows - 1) / m_rows; + nrows = m_rows; + } + else // 0 columns, 0 rows? + { + wxFAIL_MSG( _T("grid sizer must have either rows or columns fixed") ); - nrows = - ncols = 0; - } + nrows = + ncols = 0; } return nitems; -- 2.45.2