From 60b71826d657aea1ea285ec855a55cc8f44192df Mon Sep 17 00:00:00 2001 From: Francesco Montorsi Date: Fri, 28 Nov 2008 21:50:22 +0000 Subject: [PATCH] return wxDefaultSize (as done in all other platforms) when the combo box is empty git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@57013 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- interface/wx/bmpcbox.h | 3 ++- src/gtk/bmpcbox.cpp | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/interface/wx/bmpcbox.h b/interface/wx/bmpcbox.h index fcd53cab71..c073ead100 100644 --- a/interface/wx/bmpcbox.h +++ b/interface/wx/bmpcbox.h @@ -180,7 +180,8 @@ public: const wxString& name = wxBitmapComboBoxNameStr); /** - Returns size of bitmaps used in the list. + Returns the size of the bitmaps used in the combo box. + If the combo box is empty, then ::wxDefaultSize is returned. */ virtual wxSize GetBitmapSize() const; diff --git a/src/gtk/bmpcbox.cpp b/src/gtk/bmpcbox.cpp index 0378a0a0df..13fb8edf00 100644 --- a/src/gtk/bmpcbox.cpp +++ b/src/gtk/bmpcbox.cpp @@ -48,7 +48,7 @@ void wxBitmapComboBox::Init() { m_bitmapCellIndex = 0; m_stringCellIndex = 1; - m_bitmapSize = wxSize(0, 0); + m_bitmapSize = wxSize(-1, -1); } wxBitmapComboBox::wxBitmapComboBox(wxWindow *parent, @@ -129,7 +129,7 @@ void wxBitmapComboBox::GTKCreateComboBoxWidget() // This must be called as gtk_combo_box_entry_new_with_model adds // automatically adds one text column. - gtk_cell_layout_clear( GTK_CELL_LAYOUT(m_widget) ); + gtk_cell_layout_clear( GTK_CELL_LAYOUT(m_widget) ); GtkCellRenderer* imageRenderer = gtk_cell_renderer_pixbuf_new(); gtk_cell_layout_pack_start( GTK_CELL_LAYOUT(m_widget), @@ -160,7 +160,7 @@ GdkWindow *wxBitmapComboBox::GTKGetWindow(wxArrayGdkWindows& windows) const { if ( GetEntry() ) return wxComboBox::GTKGetWindow(windows); - + return wxChoice::GTKGetWindow(windows); } @@ -172,7 +172,7 @@ void wxBitmapComboBox::SetItemBitmap(unsigned int n, const wxBitmap& bitmap) { if ( bitmap.IsOk() ) { - if ( m_bitmapSize.x == 0 ) + if ( m_bitmapSize.x < 0 ) { m_bitmapSize.x = bitmap.GetWidth(); m_bitmapSize.y = bitmap.GetHeight(); -- 2.45.2