From 581ee8a9c5cc369e556b6749fe106fe2f95ce7bc Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 24 Mar 2003 23:03:19 +0000 Subject: [PATCH] implemented Remove() and Replace() for GTK2 (patch 705051 from Nerijus) git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@19786 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- docs/toback24.txt | 8 ++++++++ src/gtk/textctrl.cpp | 27 +++++++++++++++++++++------ src/gtk1/textctrl.cpp | 27 +++++++++++++++++++++------ 3 files changed, 50 insertions(+), 12 deletions(-) diff --git a/docs/toback24.txt b/docs/toback24.txt index 41ac59f0f3..a45bdf7828 100644 --- a/docs/toback24.txt +++ b/docs/toback24.txt @@ -482,3 +482,11 @@ Checking in src/msw/radiobut.cpp; /pack/cvsroots/wxwindows/wxWindows/src/msw/radiobut.cpp,v <-- radiobut.cpp new revision: 1.32; previous revision: 1.31 +42. Implement wxTextCtrl::Remove/Replace() for GTK2 + +http://sf.net/tracker/index.php?func=detail&aid=705051&group_id=9863&atid=309863 + +Checking in src/gtk/textctrl.cpp; +/pack/cvsroots/wxwindows/wxWindows/src/gtk/textctrl.cpp,v <-- textctrl.cpp +new revision: 1.154; previous revision: 1.153 + diff --git a/src/gtk/textctrl.cpp b/src/gtk/textctrl.cpp index 5ff7ea5c60..c91af21b5e 100644 --- a/src/gtk/textctrl.cpp +++ b/src/gtk/textctrl.cpp @@ -1078,29 +1078,44 @@ void wxTextCtrl::Remove( long from, long to ) { wxCHECK_RET( m_text != NULL, wxT("invalid text ctrl") ); -#ifndef __WXGTK20__ - gtk_editable_delete_text( GTK_EDITABLE(m_text), (gint)from, (gint)to ); +#ifdef __WXGTK20__ + if ( m_windowStyle & wxTE_MULTILINE ) + { + GtkTextBuffer * + text_buffer = gtk_text_view_get_buffer( GTK_TEXT_VIEW(m_text) ); + + GtkTextIter fromi, toi; + gtk_text_buffer_get_iter_at_offset( text_buffer, &fromi, from ); + gtk_text_buffer_get_iter_at_offset( text_buffer, &toi, to ); + + gtk_text_buffer_delete( text_buffer, &fromi, &toi ); + } + else // single line #endif + gtk_editable_delete_text( GTK_EDITABLE(m_text), (gint)from, (gint)to ); } void wxTextCtrl::Replace( long from, long to, const wxString &value ) { wxCHECK_RET( m_text != NULL, wxT("invalid text ctrl") ); -#ifndef __WXGTK20__ - gtk_editable_delete_text( GTK_EDITABLE(m_text), (gint)from, (gint)to ); + Remove( from, to ); if (!value.IsEmpty()) { +#ifdef __WXGTK20__ + SetInsertionPoint( from ); + WriteText( value ); +#else // GTK 1.x gint pos = (gint)from; #if wxUSE_UNICODE wxWX2MBbuf buf = value.mbc_str(); gtk_editable_insert_text( GTK_EDITABLE(m_text), buf, strlen(buf), &pos ); #else gtk_editable_insert_text( GTK_EDITABLE(m_text), value, value.Length(), &pos ); -#endif +#endif // wxUSE_UNICODE +#endif // GTK 1.x/2.x } -#endif } void wxTextCtrl::Cut() diff --git a/src/gtk1/textctrl.cpp b/src/gtk1/textctrl.cpp index 5ff7ea5c60..c91af21b5e 100644 --- a/src/gtk1/textctrl.cpp +++ b/src/gtk1/textctrl.cpp @@ -1078,29 +1078,44 @@ void wxTextCtrl::Remove( long from, long to ) { wxCHECK_RET( m_text != NULL, wxT("invalid text ctrl") ); -#ifndef __WXGTK20__ - gtk_editable_delete_text( GTK_EDITABLE(m_text), (gint)from, (gint)to ); +#ifdef __WXGTK20__ + if ( m_windowStyle & wxTE_MULTILINE ) + { + GtkTextBuffer * + text_buffer = gtk_text_view_get_buffer( GTK_TEXT_VIEW(m_text) ); + + GtkTextIter fromi, toi; + gtk_text_buffer_get_iter_at_offset( text_buffer, &fromi, from ); + gtk_text_buffer_get_iter_at_offset( text_buffer, &toi, to ); + + gtk_text_buffer_delete( text_buffer, &fromi, &toi ); + } + else // single line #endif + gtk_editable_delete_text( GTK_EDITABLE(m_text), (gint)from, (gint)to ); } void wxTextCtrl::Replace( long from, long to, const wxString &value ) { wxCHECK_RET( m_text != NULL, wxT("invalid text ctrl") ); -#ifndef __WXGTK20__ - gtk_editable_delete_text( GTK_EDITABLE(m_text), (gint)from, (gint)to ); + Remove( from, to ); if (!value.IsEmpty()) { +#ifdef __WXGTK20__ + SetInsertionPoint( from ); + WriteText( value ); +#else // GTK 1.x gint pos = (gint)from; #if wxUSE_UNICODE wxWX2MBbuf buf = value.mbc_str(); gtk_editable_insert_text( GTK_EDITABLE(m_text), buf, strlen(buf), &pos ); #else gtk_editable_insert_text( GTK_EDITABLE(m_text), value, value.Length(), &pos ); -#endif +#endif // wxUSE_UNICODE +#endif // GTK 1.x/2.x } -#endif } void wxTextCtrl::Cut() -- 2.45.2