From 5431e4a68473e31cc6870d67577aa12a2fb39fa4 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Thu, 25 Feb 2010 00:03:59 +0000 Subject: [PATCH] Use wxGetInstance() instead of wxhInstance in wxMSW code. No real changes, just use an accessor function instead of directly accessing the global variable. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63554 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/msw/private.h | 16 ++++++++-------- src/msw/app.cpp | 8 ++++---- src/msw/msgdlg.cpp | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/include/wx/msw/private.h b/include/wx/msw/private.h index 2d75ccdf6a..9683257776 100644 --- a/include/wx/msw/private.h +++ b/include/wx/msw/private.h @@ -62,6 +62,13 @@ extern WXDLLIMPEXP_DATA_CORE(HFONT) wxSTATUS_LINE_FONT; extern WXDLLIMPEXP_DATA_BASE(HINSTANCE) wxhInstance; +extern "C" +{ + WXDLLIMPEXP_BASE HINSTANCE wxGetInstance(); +} + +WXDLLIMPEXP_BASE void wxSetInstance(HINSTANCE hInst); + // --------------------------------------------------------------------------- // define things missing from some compilers' headers // --------------------------------------------------------------------------- @@ -769,7 +776,7 @@ public: { if ( IsRegistered() ) { - if ( !::UnregisterClass(m_clsname.wx_str(), wxhInstance) ) + if ( !::UnregisterClass(m_clsname.wx_str(), wxGetInstance()) ) { wxLogLastError(wxT("UnregisterClass")); } @@ -839,13 +846,6 @@ private: // global functions // --------------------------------------------------------------------------- -extern "C" -{ - WXDLLIMPEXP_BASE HINSTANCE wxGetInstance(); -} - -WXDLLIMPEXP_BASE void wxSetInstance(HINSTANCE hInst); - // return the full path of the given module inline wxString wxGetFullModuleName(HMODULE hmod) { diff --git a/src/msw/app.cpp b/src/msw/app.cpp index 0e79d4627f..037032c870 100644 --- a/src/msw/app.cpp +++ b/src/msw/app.cpp @@ -659,7 +659,7 @@ const wxChar *wxApp::GetRegisteredClassName(const wxChar *name, wxZeroMemory(wndclass); wndclass.lpfnWndProc = (WNDPROC)wxWndProc; - wndclass.hInstance = wxhInstance; + wndclass.hInstance = wxGetInstance(); wndclass.hCursor = ::LoadCursor(NULL, IDC_ARROW); wndclass.hbrBackground = (HBRUSH)wxUIntToPtr(bgBrushCol + 1); wndclass.style = CS_HREDRAW | CS_VREDRAW | CS_DBLCLKS | extraStyles; @@ -693,7 +693,7 @@ const wxChar *wxApp::GetRegisteredClassName(const wxChar *name, { wxLogLastError(wxString::Format(wxT("RegisterClass(%s)"), regClass.regname)); - ::UnregisterClass(regClass.regname.c_str(), wxhInstance); + ::UnregisterClass(regClass.regname.c_str(), wxGetInstance()); return NULL; } @@ -725,13 +725,13 @@ void wxApp::UnregisterWindowClasses() for ( size_t n = 0; n < count; n++ ) { const ClassRegInfo& regClass = gs_regClassesInfo[n]; - if ( !::UnregisterClass(regClass.regname.c_str(), wxhInstance) ) + if ( !::UnregisterClass(regClass.regname.c_str(), wxGetInstance()) ) { wxLogLastError(wxString::Format(wxT("UnregisterClass(%s)"), regClass.regname)); } - if ( !::UnregisterClass(regClass.regnameNR.c_str(), wxhInstance) ) + if ( !::UnregisterClass(regClass.regnameNR.c_str(), wxGetInstance()) ) { wxLogLastError(wxString::Format(wxT("UnregisterClass(%s)"), regClass.regnameNR)); diff --git a/src/msw/msgdlg.cpp b/src/msw/msgdlg.cpp index d0ddb15ac0..43ed4e1c6e 100644 --- a/src/msw/msgdlg.cpp +++ b/src/msw/msgdlg.cpp @@ -267,7 +267,7 @@ void wxMessageDialog::ReplaceStaticWithEdit() rc.right - rc.left, rc.bottom - rc.top, GetHwnd(), NULL, - wxhInstance, + wxGetInstance(), NULL ); -- 2.45.2