From 525711d7a36478245a6cce2ac54fdbae0d180058 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Wed, 1 Apr 2009 21:49:47 +0000 Subject: [PATCH] don't run wxPATH_NORM_LONG test on systems where the short file names are disabled git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@59974 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- tests/filename/filenametest.cpp | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/tests/filename/filenametest.cpp b/tests/filename/filenametest.cpp index 3f72d84..711233d 100644 --- a/tests/filename/filenametest.cpp +++ b/tests/filename/filenametest.cpp @@ -24,6 +24,10 @@ #include "wx/filename.h" #include "wx/filefn.h" +#ifdef __WXMSW__ + #include "wx/msw/registry.h" +#endif // __WXMSW__ + // ---------------------------------------------------------------------------- // local functions // ---------------------------------------------------------------------------- @@ -345,9 +349,6 @@ void FileNameTestCase::TestNormalize() { ".\\foo", wxPATH_NORM_LONG, ".\\foo", wxPATH_DOS }, { "..\\Makefile.in", wxPATH_NORM_LONG, "..\\Makefile.in", wxPATH_DOS }, { "..\\foo", wxPATH_NORM_LONG, "..\\foo", wxPATH_DOS }, -#ifdef __WXMSW__ - { "..\\MKINST~1", wxPATH_NORM_LONG, "..\\mkinstalldirs", wxPATH_DOS }, -#endif }; // set the env var ABCDEF @@ -375,6 +376,29 @@ void FileNameTestCase::TestNormalize() expected, fn.GetFullPath(fnt.fmt) ); } + + // MSW-only test for wxPATH_NORM_LONG: notice that we only run it if short + // names generation is not disabled for this system as otherwise the file + // MKINST~1 doesn't exist at all and normalizing it fails (it's possible + // that we're on a FAT partition in which case the test would still succeed + // and also that the registry key was changed recently and didn't take + // effect yet but these are marginal cases which we consciously choose to + // ignore for now) +#ifdef __WXMSW__ + long shortNamesDisabled; + if ( wxRegKey + ( + wxRegKey::HKLM, + "SYSTEM\\CurrentControlSet\\Control\\FileSystem" + ).QueryValue("NtfsDisable8dot3NameCreation", &shortNamesDisabled) && + !shortNamesDisabled ) + { + wxFileName fn("..\\MKINST~1"); + CPPUNIT_ASSERT( fn.Normalize(wxPATH_NORM_LONG, cwd) ); + CPPUNIT_ASSERT_EQUAL( "..\\mkinstalldirs", fn.GetFullPath() ); + } + //else: when in doubt, don't run the test +#endif // __WXMSW__ } void FileNameTestCase::TestReplace() -- 2.7.4