From 2fd85ab3e86fceb569c982a4ee3555a98bcf5786 Mon Sep 17 00:00:00 2001
From: =?utf8?q?V=C3=A1clav=20Slav=C3=ADk?= <vslavik@fastmail.fm>
Date: Thu, 17 Aug 2006 16:08:13 +0000
Subject: [PATCH] avoid calling wxSystemSettings::GetMetric() from
 wxIconBundle::GetIcon() unless the returned value is really needed to choose
 from >1 icons

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@40654 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---
 src/common/iconbndl.cpp | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/src/common/iconbndl.cpp b/src/common/iconbndl.cpp
index 4a0b326a64..e15376f5bb 100644
--- a/src/common/iconbndl.cpp
+++ b/src/common/iconbndl.cpp
@@ -78,16 +78,29 @@ void wxIconBundle::AddIcon( const wxString& WXUNUSED(file), long WXUNUSED(type)
 
 const wxIcon& wxIconBundle::GetIcon( const wxSize& size ) const
 {
-    size_t i, max = m_icons.GetCount();
+    // temp. variable needed to fix Borland C++ 5.5.1 problem
+    // with passing a return value through two functions
+    wxIcon *tmp;
+
+    size_t max = m_icons.GetCount();
+
+    // if we have one or no icon, we can return now without doing more work:
+    if ( max <= 1 )
+    {
+        if ( max == 1 ) // fix for broken BCC
+            tmp = &m_icons[0];
+        else // max == 0
+            tmp = &wxNullIcon;
+        return *tmp;
+    }
+
+    // there are more icons, find the best match:
     wxCoord sysX = wxSystemSettings::GetMetric( wxSYS_ICON_X ),
             sysY = wxSystemSettings::GetMetric( wxSYS_ICON_Y );
 
     wxIcon *sysIcon = 0;
-    // temp. variable needed to fix Borland C++ 5.5.1 problem
-    // with passing a return value through two functions
-    wxIcon *tmp;
 
-    for( i = 0; i < max; i++ )
+    for( size_t i = 0; i < max; i++ )
     {
         if( !m_icons[i].Ok() )
             continue;
@@ -105,11 +118,8 @@ const wxIcon& wxIconBundle::GetIcon( const wxSize& size ) const
 
     // return the system-sized icon if we've got one
     if( sysIcon ) return *sysIcon;
-    // return the first icon, if we have one
-    if( max > 0 ) // fix for broken BCC
-        tmp = &m_icons[0];
-    else
-        tmp = &wxNullIcon;
+    // we certainly have at least one icon thanks to the <=1 check above
+    tmp = &m_icons[0];
     return *tmp;
 }
 
-- 
2.45.2