From 17520c84b310d2554128acabb02059c89206cefc Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Wed, 12 Nov 2008 14:36:21 +0000 Subject: [PATCH] added self-assignment check to wxListItem::operator=() git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@56745 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/listbase.h | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/include/wx/listbase.h b/include/wx/listbase.h index 4fad38b7a4..d8738e86ec 100644 --- a/include/wx/listbase.h +++ b/include/wx/listbase.h @@ -238,17 +238,20 @@ public: wxListItem& operator=(const wxListItem& item) { - m_mask = item.m_mask; - m_itemId = item.m_itemId; - m_col = item.m_col; - m_state = item.m_state; - m_stateMask = item.m_stateMask; - m_text = item.m_text; - m_image = item.m_image; - m_data = item.m_data; - m_format = item.m_format; - m_width = item.m_width; - m_attr = item.m_attr ? new wxListItemAttr(*item.m_attr) : NULL; + if ( &item != this ) + { + m_mask = item.m_mask; + m_itemId = item.m_itemId; + m_col = item.m_col; + m_state = item.m_state; + m_stateMask = item.m_stateMask; + m_text = item.m_text; + m_image = item.m_image; + m_data = item.m_data; + m_format = item.m_format; + m_width = item.m_width; + m_attr = item.m_attr ? new wxListItemAttr(*item.m_attr) : NULL; + } return *this; } -- 2.45.2