From 168a76fe3d8c0655da7c6f79c26eb914957b5849 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 6 May 2006 18:53:43 +0000 Subject: [PATCH] corrected last change to cWC2MB() to also work for encoding with NUL length > 1 git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@39076 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/common/strconv.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/common/strconv.cpp b/src/common/strconv.cpp index 4e62a144b1..f4a58755c3 100644 --- a/src/common/strconv.cpp +++ b/src/common/strconv.cpp @@ -425,13 +425,9 @@ wxMBConv::cWC2MB(const wchar_t *inBuff, size_t inLen, size_t *outLen) const size_t dstLen = FromWChar(NULL, 0, inBuff, inLen); if ( dstLen != wxCONV_FAILED ) { - if ( !dstLen ) - { - // special case: can't allocate 0 size buffer below - dstLen++; - } - - wxCharBuffer buf(dstLen - 1); + // special case of empty input: can't allocate 0 size buffer below as + // wxCharBuffer insists on NUL-terminating it + wxCharBuffer buf(dstLen ? dstLen - 1 : 1); if ( FromWChar(buf.data(), dstLen, inBuff, inLen) != wxCONV_FAILED ) { if ( outLen ) -- 2.45.2