From 14ca93a0d9a025c6620eaa94ac0687e44c31e234 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 6 Feb 2005 01:52:19 +0000 Subject: [PATCH] two changes and some cleanup: 1. DECLARE_ABSTRACT_CLASS() shouldn't declare wxCreateObject() (which is not defined by IMPLEMENT_ABSTRACT_CLASS()) 2. don't make GetClassInfo() declaration inside DECLARE_CLASS inline in an attempt to fix linking problems with HP-UX compiler git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@31775 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/object.h | 83 +++++++++++++++++++++++-------------------- src/common/object.cpp | 5 +++ 2 files changed, 49 insertions(+), 39 deletions(-) diff --git a/include/wx/object.h b/include/wx/object.h index 11ffa2b356..43e96756eb 100644 --- a/include/wx/object.h +++ b/include/wx/object.h @@ -156,48 +156,59 @@ inline void wxClassInfo::CleanUpClasses() {} // Dynamic class macros // ---------------------------------------------------------------------------- -#define DECLARE_DYNAMIC_CLASS(name) \ - public: \ - static wxClassInfo ms_classInfo; \ - static wxObject* wxCreateObject(); \ - virtual wxClassInfo *GetClassInfo() const \ - { return &name::ms_classInfo; } - -#define DECLARE_DYNAMIC_CLASS_NO_ASSIGN(name) \ - DECLARE_NO_ASSIGN_CLASS(name) \ +#define DECLARE_ABSTRACT_CLASS(name) \ + public: \ + static wxClassInfo ms_classInfo; \ + virtual wxClassInfo *GetClassInfo() const; + +#define DECLARE_DYNAMIC_CLASS_NO_ASSIGN(name) \ + DECLARE_NO_ASSIGN_CLASS(name) \ DECLARE_DYNAMIC_CLASS(name) -#define DECLARE_DYNAMIC_CLASS_NO_COPY(name) \ - DECLARE_NO_COPY_CLASS(name) \ +#define DECLARE_DYNAMIC_CLASS_NO_COPY(name) \ + DECLARE_NO_COPY_CLASS(name) \ DECLARE_DYNAMIC_CLASS(name) -#define DECLARE_ABSTRACT_CLASS(name) DECLARE_DYNAMIC_CLASS(name) +#define DECLARE_DYNAMIC_CLASS(name) \ + DECLARE_ABSTRACT_CLASS(name) \ + static wxObject* wxCreateObject(); + #define DECLARE_CLASS(name) DECLARE_DYNAMIC_CLASS(name) + +// common part of the macros below +#define wxIMPLEMENT_CLASS_COMMON(name, basename, baseclsinfo2, func) \ + wxClassInfo name::ms_classInfo(wxT(#name), \ + &basename::ms_classInfo, \ + baseclsinfo2, \ + (int) sizeof(name), \ + (wxObjectConstructorFn) func); \ + \ + wxClassInfo *name::GetClassInfo() const \ + { return &name::ms_classInfo; } + +#define wxIMPLEMENT_CLASS_COMMON1(name, basename, func) \ + wxIMPLEMENT_CLASS_COMMON(name, basename, NULL, func) + +#define wxIMPLEMENT_CLASS_COMMON2(name, basename1, basename2, func) \ + wxIMPLEMENT_CLASS_COMMON(name, basename1, &basename2::ms_classInfo) + // ----------------------------------- // for concrete classes // ----------------------------------- // Single inheritance with one base class - -#define IMPLEMENT_DYNAMIC_CLASS(name, basename) \ - wxObject* name::wxCreateObject() \ - { return new name; } \ - wxClassInfo name::ms_classInfo(wxT(#name), \ - &basename::ms_classInfo, NULL, \ - (int) sizeof(name), \ - (wxObjectConstructorFn) name::wxCreateObject); +#define IMPLEMENT_DYNAMIC_CLASS(name, basename) \ + wxIMPLEMENT_CLASS_COMMON1(name, basename, name::wxCreateObject) \ + wxObject* name::wxCreateObject() \ + { return new name; } // Multiple inheritance with two base classes - -#define IMPLEMENT_DYNAMIC_CLASS2(name, basename1, basename2) \ - wxObject* name::wxCreateObject() \ - { return new name; } \ - wxClassInfo name::ms_classInfo(wxT(#name), \ - &basename1::ms_classInfo, \ - &basename2::ms_classInfo, \ - (int) sizeof(name), \ - (wxObjectConstructorFn) name::wxCreateObject); +#define IMPLEMENT_DYNAMIC_CLASS2(name, basename1, basename2) \ + wxIMPLEMENT_CLASS_COMMON2(name, basename1, basename2, \ + name::wxCreateObject) \ + wxObject* name::wxCreateObject() \ + { return new name; } // ----------------------------------- // for abstract classes @@ -205,19 +216,13 @@ inline void wxClassInfo::CleanUpClasses() {} // Single inheritance with one base class -#define IMPLEMENT_ABSTRACT_CLASS(name, basename) \ - wxClassInfo name::ms_classInfo(wxT(#name), \ - &basename::ms_classInfo, NULL, \ - (int) sizeof(name), (wxObjectConstructorFn) 0); +#define IMPLEMENT_ABSTRACT_CLASS(name, basename) \ + wxIMPLEMENT_CLASS_COMMON1(name, basename, NULL) // Multiple inheritance with two base classes -#define IMPLEMENT_ABSTRACT_CLASS2(name, basename1, basename2) \ - wxClassInfo name::ms_classInfo(wxT(#name), \ - &basename1::ms_classInfo, \ - &basename2::ms_classInfo, \ - (int) sizeof(name), \ - (wxObjectConstructorFn) 0); +#define IMPLEMENT_ABSTRACT_CLASS2(name, basename1, basename2) \ + wxIMPLEMENT_CLASS_COMMON2(name, basename1, basename2, NULL) #define IMPLEMENT_CLASS IMPLEMENT_ABSTRACT_CLASS #define IMPLEMENT_CLASS2 IMPLEMENT_ABSTRACT_CLASS2 diff --git a/src/common/object.cpp b/src/common/object.cpp index e6852e8e76..605eb33b43 100644 --- a/src/common/object.cpp +++ b/src/common/object.cpp @@ -81,6 +81,11 @@ wxClassInfo wxObject::ms_classInfo( wxT("wxObject"), 0, 0, wxClassInfo* wxClassInfo::sm_first = NULL; wxHashTable* wxClassInfo::sm_classTable = NULL; +wxClassInfo *wxObject::GetClassInfo() const +{ + return &wxObject::ms_classInfo; +} + // These are here so we can avoid 'always true/false' warnings // by referring to these instead of true/false const bool wxTrue = true; -- 2.45.2