From 0e0f825d7c5ab67ae5349300345c75c90c8b7d60 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 9 Mar 2013 15:07:56 +0000 Subject: [PATCH] Remove wxLogWindow::OnFrameCreate() virtual method. This method couldn't be overridden by the classes deriving from wxLogWindow because it was called (indirectly) from wxLogWindow ctor itself and so was completely useless. Just remove it to avoid confusion. Closes #12763. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@73622 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- docs/changes.txt | 1 + include/wx/generic/logg.h | 3 --- interface/wx/log.h | 6 ------ src/generic/logg.cpp | 6 ------ 4 files changed, 1 insertion(+), 15 deletions(-) diff --git a/docs/changes.txt b/docs/changes.txt index 74939c4f0e..70ec5413a2 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -622,6 +622,7 @@ All (GUI): - Add wxCheckListBox::GetCheckedItems() (hartwigw). - Add wxAUI_TB_PLAIN_BACKGROUND wxAuiToolBar style (Allann Jones). - Make wxGenericDataViewCtrl::SetFont() really work (Laurent Poujoulat). +- Remove wxLogWindow::OnFrameCreate(), it was never called anyhow. wxGTK: diff --git a/include/wx/generic/logg.h b/include/wx/generic/logg.h index 4cff569de0..b7409d4610 100644 --- a/include/wx/generic/logg.h +++ b/include/wx/generic/logg.h @@ -127,9 +127,6 @@ public: wxFrame *GetFrame() const; // overridables - // called immediately after the log frame creation allowing for - // any extra initializations - virtual void OnFrameCreate(wxFrame *frame); // called if the user closes the window interactively, will not be // called if it is destroyed for another reason (such as when program // exits) - return true from here to allow the frame to close, false diff --git a/interface/wx/log.h b/interface/wx/log.h index 998f015959..22406b53ba 100644 --- a/interface/wx/log.h +++ b/interface/wx/log.h @@ -949,12 +949,6 @@ public: */ virtual bool OnFrameClose(wxFrame* frame); - /** - Called immediately after the log frame creation allowing for - any extra initializations. - */ - virtual void OnFrameCreate(wxFrame* frame); - /** Called right before the log frame is going to be deleted: will always be called unlike OnFrameClose(). diff --git a/src/generic/logg.cpp b/src/generic/logg.cpp index a56044a05f..43d8630305 100644 --- a/src/generic/logg.cpp +++ b/src/generic/logg.cpp @@ -529,8 +529,6 @@ wxLogFrame::wxLogFrame(wxWindow *pParent, wxLogWindow *log, const wxString& szTi // status bar for menu prompts CreateStatusBar(); #endif // wxUSE_STATUSBAR - - m_log->OnFrameCreate(this); } void wxLogFrame::DoClose() @@ -644,10 +642,6 @@ wxFrame *wxLogWindow::GetFrame() const return m_pLogFrame; } -void wxLogWindow::OnFrameCreate(wxFrame * WXUNUSED(frame)) -{ -} - bool wxLogWindow::OnFrameClose(wxFrame * WXUNUSED(frame)) { // allow to close -- 2.45.2