From 02bcd285fac7124a41292d905609220005f51087 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 25 Sep 2005 20:29:58 +0000 Subject: [PATCH] re-renamed DoCreate() to XmDoCreateTLW() to avoid virtual function hiding in other classes with their own DoCreate() and re-removed DoDestroy() git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@35692 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- include/wx/motif/dialog.h | 7 +------ include/wx/motif/frame.h | 7 +------ include/wx/motif/toplevel.h | 9 +-------- src/motif/dialog.cpp | 6 +----- src/motif/frame.cpp | 6 +----- src/motif/toplevel.cpp | 2 +- 6 files changed, 6 insertions(+), 31 deletions(-) diff --git a/include/wx/motif/dialog.h b/include/wx/motif/dialog.h index 3c8866fb1d..9fa1cfd9c1 100644 --- a/include/wx/motif/dialog.h +++ b/include/wx/motif/dialog.h @@ -75,7 +75,7 @@ public: void OnCloseWindow(wxCloseEvent& event); private: - virtual bool DoCreate(wxWindow* parent, + virtual bool XmDoCreateTLW(wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, @@ -95,11 +95,6 @@ protected: virtual void DoSetClientSize(int width, int height); -#if wxCHECK_VERSION(2,7,0) - #error "Remove DoDestroy(), it was only kept for binary backwards compatibility" -#endif - - virtual void DoDestroy(); private: DECLARE_EVENT_TABLE() diff --git a/include/wx/motif/frame.h b/include/wx/motif/frame.h index e18ef08d4e..a5cf199637 100644 --- a/include/wx/motif/frame.h +++ b/include/wx/motif/frame.h @@ -113,7 +113,7 @@ private: virtual void DoSetClientSize(int width, int height); private: - virtual bool DoCreate(wxWindow* parent, + virtual bool XmDoCreateTLW(wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, @@ -122,11 +122,6 @@ private: const wxString& name); -#if wxCHECK_VERSION(2,7,0) - #error "Remove DoDestroy(), it was only kept for binary backwards compatibility" -#endif - - virtual void DoDestroy(); DECLARE_EVENT_TABLE() DECLARE_DYNAMIC_CLASS(wxFrame) diff --git a/include/wx/motif/toplevel.h b/include/wx/motif/toplevel.h index ae5e79cce9..80e3f1d204 100644 --- a/include/wx/motif/toplevel.h +++ b/include/wx/motif/toplevel.h @@ -68,14 +68,8 @@ protected: virtual void DoGetPosition(int* x, int* y) const; private: -#if wxCHECK_VERSION(2,7,0) - // DoDestroy() is not used anywhere else, DoCreate() should also be renamed - // in src/motif/dialog.cpp, frame.cpp and toplevel.cp - #error "Remove DoDestroy() and rename DoCreate() to XmDoCreateTLW(), they were only kept for binary backwards compatibility" -#endif - // really create the Motif widget for TLW - virtual bool DoCreate(wxWindow* parent, + virtual bool XmDoCreateTLW(wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, @@ -83,7 +77,6 @@ private: long style, const wxString& name) = 0; - virtual void DoDestroy() { } wxString m_title; }; diff --git a/src/motif/dialog.cpp b/src/motif/dialog.cpp index 8f234a2f20..0b812eadba 100644 --- a/src/motif/dialog.cpp +++ b/src/motif/dialog.cpp @@ -147,7 +147,7 @@ bool wxDialog::Create(wxWindow *parent, wxWindowID id, return true; } -bool wxDialog::DoCreate(wxWindow* parent, +bool wxDialog::XmDoCreateTLW(wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, @@ -192,10 +192,6 @@ bool wxDialog::DoCreate(wxWindow* parent, return true; } -void wxDialog::DoDestroy() -{ -} - void wxDialog::SetModal(bool flag) { #ifdef __VMS diff --git a/src/motif/frame.cpp b/src/motif/frame.cpp index 56b6ddefaa..9dd9f80673 100644 --- a/src/motif/frame.cpp +++ b/src/motif/frame.cpp @@ -192,7 +192,7 @@ bool wxFrame::Create(wxWindow *parent, return true; } -bool wxFrame::DoCreate(wxWindow* parent, +bool wxFrame::XmDoCreateTLW(wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, @@ -262,10 +262,6 @@ bool wxFrame::DoCreate(wxWindow* parent, return true; } -void wxFrame::DoDestroy() -{ -} - wxFrame::~wxFrame() { m_isBeingDeleted = true; diff --git a/src/motif/toplevel.cpp b/src/motif/toplevel.cpp index 89a5d8003c..7d0613e6b8 100644 --- a/src/motif/toplevel.cpp +++ b/src/motif/toplevel.cpp @@ -117,7 +117,7 @@ bool wxTopLevelWindowMotif::Create( wxWindow *parent, wxWindowID id, m_windowId = ( id > -1 ) ? id : NewControlId(); - bool retval = DoCreate( parent, id, title, pos, size, style, name ); + bool retval = XmDoCreateTLW( parent, id, title, pos, size, style, name ); if( !retval ) return false; -- 2.45.2