From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Tue, 7 Mar 2006 23:44:25 +0000 (+0000)
Subject: removed unneeded test for pal!=NULL in ConvertToImage() (coverity checker CID 10)
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/fbf1ee1d0952fed396750cddb01e7cc7904f1d75?ds=inline

removed unneeded test for pal!=NULL in ConvertToImage() (coverity checker CID 10)


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@37886 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/gifdecod.cpp b/src/common/gifdecod.cpp
index db8ac994df..8fda5f8ae1 100644
--- a/src/common/gifdecod.cpp
+++ b/src/common/gifdecod.cpp
@@ -142,21 +142,18 @@ bool wxGIFDecoder::ConvertToImage(wxImage *image) const
         image->SetMask(false);
 
 #if wxUSE_PALETTE
-    if (pal)
-    {
-        unsigned char r[256];
-        unsigned char g[256];
-        unsigned char b[256];
+    unsigned char r[256];
+    unsigned char g[256];
+    unsigned char b[256];
 
-        for (i = 0; i < 256; i++)
-        {
-            r[i] = pal[3*i + 0];
-            g[i] = pal[3*i + 1];
-            b[i] = pal[3*i + 2];
-        }
-
-        image->SetPalette(wxPalette(256, r, g, b));
+    for (i = 0; i < 256; i++)
+    {
+        r[i] = pal[3*i + 0];
+        g[i] = pal[3*i + 1];
+        b[i] = pal[3*i + 2];
     }
+
+    image->SetPalette(wxPalette(256, r, g, b));
 #endif // wxUSE_PALETTE
 
     /* copy image data */