From: Julian Smart <julian@anthemion.co.uk>
Date: Fri, 14 Mar 2008 14:18:15 +0000 (+0000)
Subject: Fixed bug in wxDialUpManagerMSW::GetISPNames - uses realloc() without checking for... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/fb9bea06cfde83c7b4945c5b76cf94e5b58377b3

Fixed bug in wxDialUpManagerMSW::GetISPNames - uses realloc() without checking for NULL, leading to a memory leak (Sebastian Gottschalk)


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@52494 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/msw/dialup.cpp b/src/msw/dialup.cpp
index b708fb4612..566c31c335 100644
--- a/src/msw/dialup.cpp
+++ b/src/msw/dialup.cpp
@@ -709,7 +709,13 @@ size_t wxDialUpManagerMSW::GetISPNames(wxArrayString& names) const
         if ( dwRet == ERROR_BUFFER_TOO_SMALL )
         {
             // reallocate the buffer
-            rasEntries = (RASENTRYNAME *)realloc(rasEntries, size);
+            void *n  = realloc(rasEntries, size);
+            if (n == NULL)
+            {
+                free(rasEntries);
+                return 0;
+            }
+            rasEntries = (RASENTRYNAME *)n;
         }
         else if ( dwRet != 0 )
         {