From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sun, 22 Jun 2008 15:49:12 +0000 (+0000)
Subject: fix problem with label characters starting with -1 in ANSI build (#9572)
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/e453fe965695996f7796d22783fa2c77645e717d

fix problem with label characters starting with -1 in ANSI build (#9572)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54331 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/msw/control.cpp b/src/msw/control.cpp
index 24a4e37f2c..e2e7a25e1c 100644
--- a/src/msw/control.cpp
+++ b/src/msw/control.cpp
@@ -163,6 +163,20 @@ bool wxControl::MSWCreateControl(const wxChar *classname,
         return false;
     }
 
+#if !wxUSE_UNICODE
+    // Text labels starting with the character 0xff (which is a valid character
+    // in many code pages) don't appear correctly as CreateWindowEx() has some
+    // special treatment for this case, apparently the strings starting with -1
+    // are not really strings but something called "ordinals". There is no
+    // documentation about it but the fact is that the label gets mangled or
+    // not displayed at all if we don't do this, see #9572.
+    //
+    // Notice that 0xffff is not a valid Unicode character so the problem
+    // doesn't arise in Unicode build.
+    if ( !label.empty() && label[0] == -1 )
+        ::SetWindowText(GetHwnd(), label);
+#endif // !wxUSE_UNICODE
+
     // saving the label in m_labelOrig to return it verbatim
     // later in GetLabel()
     m_labelOrig = label;