From: Guillermo Rodriguez Garcia <guille@iies.es>
Date: Mon, 20 Dec 1999 22:15:16 +0000 (+0000)
Subject: strange comment in gsocket_read (?)
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/e35edde9c351bd084bd93e9a277a8b2e564b67cb?ds=sidebyside

strange comment in gsocket_read (?)


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@5042 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/msw/gsocket.c b/src/msw/gsocket.c
index 6a8c8d474c..10c1b2ab4f 100644
--- a/src/msw/gsocket.c
+++ b/src/msw/gsocket.c
@@ -655,12 +655,16 @@ int GSocket_Read(GSocket *socket, char *buffer, int size)
      * if the socket is in non-blocking mode (which is always
      * the case here, no matter the setting of GSocket itself)
      * a call to send() can fail with EWOULDBLOCK even when
-     * select() says that the socket is readable.
+     * select() says that the socket is writable.
      *
      * This can break several things because, usually, if
      * select() says that the socket is writable, it is
      * assumed that send() won't fail. To avoid this, we
      * return 0 instead of -1 for this special case.
+     *
+     * XXX - this comment seems not to belong here, and also
+     * the code is not consistent with the unix version of
+     * gsocket... what to do? (GRG)
      */
     if (WSAGetLastError() != WSAEWOULDBLOCK)
     {