From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sun, 6 Jul 2008 00:25:33 +0000 (+0000)
Subject: don't use deprecated wxToolBar::AddTool() overload taking position parameters which... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/e13edb6612bbf3e756cbd090e14e3a94a0267926

don't use deprecated wxToolBar::AddTool() overload taking position parameters which don't do anything anyhow

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54500 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/xrc/xh_toolb.cpp b/src/xrc/xh_toolb.cpp
index 7e78d22156..02f7f8893a 100644
--- a/src/xrc/xh_toolb.cpp
+++ b/src/xrc/xh_toolb.cpp
@@ -55,40 +55,26 @@ wxObject *wxToolBarXmlHandler::DoCreateResource()
     {
         wxCHECK_MSG(m_toolbar, NULL, wxT("Incorrect syntax of XRC resource: tool not within a toolbar!"));
 
-        if (GetPosition() != wxDefaultPosition)
+        wxItemKind kind = wxITEM_NORMAL;
+        if (GetBool(wxT("radio")))
+            kind = wxITEM_RADIO;
+        if (GetBool(wxT("toggle")))
         {
-            m_toolbar->AddTool(GetID(),
-                               GetBitmap(wxT("bitmap"), wxART_TOOLBAR),
-                               GetBitmap(wxT("bitmap2"), wxART_TOOLBAR),
-                               GetBool(wxT("toggle")),
-                               GetPosition().x,
-                               GetPosition().y,
-                               NULL,
-                               GetText(wxT("tooltip")),
-                               GetText(wxT("longhelp")));
-        }
-        else
-        {
-            wxItemKind kind = wxITEM_NORMAL;
-            if (GetBool(wxT("radio")))
-                kind = wxITEM_RADIO;
-            if (GetBool(wxT("toggle")))
-            {
-                wxASSERT_MSG( kind == wxITEM_NORMAL,
-                              _T("can't have both toggle and radio button at once") );
-                kind = wxITEM_CHECK;
-            }
-            m_toolbar->AddTool(GetID(),
-                               GetText(wxT("label")),
-                               GetBitmap(wxT("bitmap"), wxART_TOOLBAR),
-                               GetBitmap(wxT("bitmap2"), wxART_TOOLBAR),
-                               kind,
-                               GetText(wxT("tooltip")),
-                               GetText(wxT("longhelp")));
-
-            if ( GetBool(wxT("disabled")) )
-                m_toolbar->EnableTool(GetID(), false);
+            wxASSERT_MSG( kind == wxITEM_NORMAL,
+                          _T("can't have both toggle and radio button at once") );
+            kind = wxITEM_CHECK;
         }
+        m_toolbar->AddTool(GetID(),
+                           GetText(wxT("label")),
+                           GetBitmap(wxT("bitmap"), wxART_TOOLBAR),
+                           GetBitmap(wxT("bitmap2"), wxART_TOOLBAR),
+                           kind,
+                           GetText(wxT("tooltip")),
+                           GetText(wxT("longhelp")));
+
+        if ( GetBool(wxT("disabled")) )
+            m_toolbar->EnableTool(GetID(), false);
+
         return m_toolbar; // must return non-NULL
     }