From: Václav Slavík Date: Thu, 11 Feb 2010 12:36:16 +0000 (+0000) Subject: Fixed possible buffer overflow in wxXmlResource::GetXRCID() (patch #11715). X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/e03951b772a4e202282fbbd6eb4ff618204148db Fixed possible buffer overflow in wxXmlResource::GetXRCID() (patch #11715). git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@63464 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- diff --git a/src/xrc/xmlres.cpp b/src/xrc/xmlres.cpp index 5b41a453aa..88fa86ab4a 100644 --- a/src/xrc/xmlres.cpp +++ b/src/xrc/xmlres.cpp @@ -1996,9 +1996,9 @@ static XRCID_record *XRCID_Records[XRCID_TABLE_SIZE] = {NULL}; static int XRCID_Lookup(const char *str_id, int value_if_not_found = wxID_NONE) { - int index = 0; + unsigned int index = 0; - for (const char *c = str_id; *c != '\0'; c++) index += (int)*c; + for (const char *c = str_id; *c != '\0'; c++) index += (unsigned int)*c; index %= XRCID_TABLE_SIZE; XRCID_record *oldrec = NULL;