From: Jaakko Salli <jaakko.salli@dnainternet.net>
Date: Tue, 1 Jun 2010 15:01:59 +0000 (+0000)
Subject: In wxComboPopupEvtHandler::OnMouseEvent(), when need to relay event to drop-down... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/db3d75435a6f5750e2411a9456627a195dfb2d99

In wxComboPopupEvtHandler::OnMouseEvent(), when need to relay event to drop-down button, call HandleButtonMouseEvent() directly, if possible. This is less confusing for the platform-specific wxComboCtrl implementations, and fixes issue where the drop-down button could remain in pressed state after the mouse button was lifted.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@64457 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/include/wx/combo.h b/include/wx/combo.h
index b991ad7aa9..cfb202be2b 100644
--- a/include/wx/combo.h
+++ b/include/wx/combo.h
@@ -142,6 +142,7 @@ struct wxComboCtrlFeatures
 class WXDLLIMPEXP_CORE wxComboCtrlBase : public wxControl
 {
     friend class wxComboPopup;
+    friend class wxComboPopupEvtHandler;
 public:
     // ctors and such
     wxComboCtrlBase() : wxControl() { Init(); }
diff --git a/src/common/combocmn.cpp b/src/common/combocmn.cpp
index 10e0da7dcd..a050bd6cf2 100644
--- a/src/common/combocmn.cpp
+++ b/src/common/combocmn.cpp
@@ -760,6 +760,12 @@ void wxComboPopupEvtHandler::OnMouseEvent( wxMouseEvent& event )
                 // block this one)
                 m_blockEventsToPopup = false;
                 event.Skip(false);
+
+                // Also, this button press was (probably) used to display
+                // the popup, so relay it back to the drop-down button
+                // (which supposedly originated it). This is necessary to
+                // refresh it properly.
+                relayToButton = true;
             }
         }
         else if ( m_blockEventsToPopup )
@@ -789,12 +795,14 @@ void wxComboPopupEvtHandler::OnMouseEvent( wxMouseEvent& event )
 
     if ( relayToButton )
     {
-        wxWindow* eventSink = m_combo;
         wxWindow* btn = m_combo->GetButton();
         if ( btn )
-            eventSink = btn;
-
-        eventSink->GetEventHandler()->ProcessEvent(event);
+            btn->GetEventHandler()->ProcessEvent(event);
+        else
+            // Bypass the event handling mechanism. Using it would be
+            // confusing for the platform-specific wxComboCtrl
+            // implementations.
+            m_combo->HandleButtonMouseEvent(event, 0);
     }
 }