From: Włodzimierz Skiba <abx@abx.art.pl>
Date: Wed, 14 Jun 2006 16:42:35 +0000 (+0000)
Subject: Code symetry for both directions of trimming towards fixing bug #1472688.
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/d4d02bd56540d1f552b93a300f8df5307130c3b1

Code symetry for both directions of trimming towards fixing bug #1472688.


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@39723 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/string.cpp b/src/common/string.cpp
index 53a6e680fb..0a70d793a8 100644
--- a/src/common/string.cpp
+++ b/src/common/string.cpp
@@ -1617,19 +1617,18 @@ wxString& wxString::Trim(bool bFromRight)
         if ( bFromRight )
         {
             // find last non-space character
-            iterator psz = begin() + length() - 1;
-            while ( wxSafeIsspace(*psz) && (psz >= begin()) )
-                psz--;
-
+            reverse_iterator psz = rbegin();
+            while ( wxSafeIsspace(*psz) && (psz != rend()) )
+                psz++;
+            
             // truncate at trailing space start
-            *++psz = wxT('\0');
-            erase(psz, end());
+            erase(psz.base(), end());
         }
         else
         {
             // find first non-space character
             iterator psz = begin();
-            while ( wxSafeIsspace(*psz) )
+            while ( wxSafeIsspace(*psz) && (psz != end()) )
                 psz++;
 
             // fix up data and length