From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Mon, 17 Jul 2006 10:42:55 +0000 (+0000)
Subject: fixed crash in wxDb::Open() in Unicode build due to wrong interpretation of BufferLen... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/cd7e925abb316e7f15632d486e4e51d46f893c66

fixed crash in wxDb::Open() in Unicode build due to wrong interpretation of BufferLength argument of SQLDriverConnect()


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@40160 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/docs/changes.txt b/docs/changes.txt
index 33f4128f38..13f25fa595 100644
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -85,6 +85,7 @@ All:
 - Added wxPowerEvent (currently MSW-only).
 - Make wx-config compatible with Bourne shells.
 - Fixed wxDb::Open(wxDbConnectInf) when using connection string (Hellwolf Misty)
+- Fixed crash in wxDb::Open() in Unicode build (Massimiliano Marretta)
 
 All (GUI):
 
diff --git a/src/common/db.cpp b/src/common/db.cpp
index d7843f4f39..a43f461158 100644
--- a/src/common/db.cpp
+++ b/src/common/db.cpp
@@ -858,7 +858,7 @@ bool wxDb::Open(const wxString& inConnectStr, SQLHWND parentWnd, bool failOnData
 
     retcode = SQLDriverConnect(hdbc, parentWnd, (SQLTCHAR FAR *)inConnectionStr.c_str(),
                         (SWORD)inConnectionStr.length(), (SQLTCHAR FAR *)outConnectBuffer,
-                        sizeof(outConnectBuffer), &outConnectBufferLen, SQL_DRIVER_COMPLETE );
+                        WXSIZEOF(outConnectBuffer), &outConnectBufferLen, SQL_DRIVER_COMPLETE );
 
     if ((retcode != SQL_SUCCESS) &&
         (retcode != SQL_SUCCESS_WITH_INFO))
@@ -963,7 +963,7 @@ bool wxDb::Open(wxDb *copyDb)
 
         retcode = SQLDriverConnect(hdbc, NULL, (SQLTCHAR FAR *)inConnectionStr.c_str(),
                             (SWORD)inConnectionStr.length(), (SQLTCHAR FAR *)outConnectBuffer,
-                            sizeof(outConnectBuffer), &outConnectBufferLen, SQL_DRIVER_COMPLETE);
+                            WXSIZEOF(outConnectBuffer), &outConnectBufferLen, SQL_DRIVER_COMPLETE);
 
         if ((retcode != SQL_SUCCESS) &&
             (retcode != SQL_SUCCESS_WITH_INFO))