From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Fri, 12 Jul 2013 14:12:44 +0000 (+0000)
Subject: Fix harmless MinGW warning in wxMSW wxListCtrl code.
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/cd709fcebc0a8c6c2f529cf4cf9d93402a500d2e

Fix harmless MinGW warning in wxMSW wxListCtrl code.

Add an explicit cast to WPARAM because MinGW headers don't do it for us (even
though they should).

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74495 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/msw/listctrl.cpp b/src/msw/listctrl.cpp
index 9684bf0e9a..9befc6a955 100644
--- a/src/msw/listctrl.cpp
+++ b/src/msw/listctrl.cpp
@@ -1339,7 +1339,10 @@ void wxListCtrl::AssignImageList(wxImageList *imageList, int which)
 
 wxSize wxListCtrl::MSWGetBestViewRect(int x, int y) const
 {
-    const DWORD rc = ListView_ApproximateViewRect(GetHwnd(), x, y, -1);
+    // The cast is necessary to suppress a MinGW warning due to a missing cast
+    // to WPARAM in the definition of ListView_ApproximateViewRect() in its
+    // own headers (this was the case up to at least MinGW 4.8).
+    const DWORD rc = ListView_ApproximateViewRect(GetHwnd(), x, y, (WPARAM)-1);
 
     wxSize size(LOWORD(rc), HIWORD(rc));