From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Thu, 8 Mar 2007 00:44:54 +0000 (+0000)
Subject: don't use font sizes less than 1 with Pango (remaining part of patch 1671684); refact... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/cb5ec61f651e62d7028abb8d60a11efa786a7466?ds=inline

don't use font sizes less than 1 with Pango (remaining part of patch 1671684); refactor the font size setting code to eliminate duplication


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@44677 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/x11/font.cpp b/src/x11/font.cpp
index 5b37c975e8..859175c11b 100644
--- a/src/x11/font.cpp
+++ b/src/x11/font.cpp
@@ -187,12 +187,6 @@ void wxFontRefData::Init(int pointSize,
     m_style = style == wxDEFAULT ? wxFONTSTYLE_NORMAL : style;
     m_weight = weight == wxDEFAULT ? wxFONTWEIGHT_NORMAL : weight;
 
-    // and here, do we really want to forbid creation of the font of the size
-    // 90 (the value of wxDEFAULT)??
-    m_pointSize = pointSize == wxDEFAULT || pointSize == -1
-                    ? wxDEFAULT_FONT_SIZE
-                    : pointSize;
-
     m_underlined = underlined;
     m_encoding = encoding;
 
@@ -229,10 +223,11 @@ void wxFontRefData::Init(int pointSize,
     }
 
     m_nativeFontInfo.SetFaceName(m_faceName);
-    m_nativeFontInfo.SetPointSize(m_pointSize);
     m_nativeFontInfo.SetWeight((wxFontWeight)m_weight);
     m_nativeFontInfo.SetStyle((wxFontStyle)m_style);
 #endif // wxUSE_UNICODE
+
+    SetPointSize(pointSize);
 }
 
 void wxFontRefData::InitFromNative()
@@ -470,13 +465,12 @@ wxFontRefData::~wxFontRefData()
 
 void wxFontRefData::SetPointSize(int pointSize)
 {
-    m_pointSize = pointSize;
+    // NB: Pango doesn't support point sizes less than 1
+    m_pointSize = pointSize == wxDEFAULT || pointSize < 1 ? wxDEFAULT_FONT_SIZE
+                                                          : pointSize;
 
 #if wxUSE_UNICODE
-    // Get native info
-    PangoFontDescription *desc = m_nativeFontInfo.description;
-
-    pango_font_description_set_size( desc, m_pointSize * PANGO_SCALE );
+    m_nativeFontInfo.SetPointSize(m_pointSize);
 #endif
 }