From: Robert Roebling <robert@roebling.de>
Date: Wed, 18 Aug 2010 21:29:53 +0000 (+0000)
Subject: make wxChoice and wxComboBox sort in a case insensitive and locale adapted way, fixes... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/c272f12ff0c51c345e3102d3cd347412bbb99461

make wxChoice and wxComboBox sort in a case insensitive and locale adapted way, fixes #12351: Incorrect sort order in wxChoice / wxComboBox

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65342 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/include/wx/gtk/choice.h b/include/wx/gtk/choice.h
index 31704b746c..e5da9b413d 100644
--- a/include/wx/gtk/choice.h
+++ b/include/wx/gtk/choice.h
@@ -17,6 +17,8 @@ class WXDLLIMPEXP_FWD_BASE wxArrayString;
 // wxChoice
 //-----------------------------------------------------------------------------
 
+class wxGtkCollatedArrayString;
+
 class WXDLLIMPEXP_CORE wxChoice : public wxChoiceBase
 {
 public:
@@ -84,7 +86,7 @@ public:
 protected:
     // this array is only used for controls with wxCB_SORT style, so only
     // allocate it if it's needed (hence using pointer)
-    wxSortedArrayString *m_strings;
+    wxGtkCollatedArrayString *m_strings;
 
     // contains the client data for the items
     wxArrayPtrVoid m_clientData;
diff --git a/include/wx/gtk/private/string.h b/include/wx/gtk/private/string.h
index a537667166..8be04b483f 100644
--- a/include/wx/gtk/private/string.h
+++ b/include/wx/gtk/private/string.h
@@ -31,5 +31,90 @@ private:
     wxDECLARE_NO_COPY_CLASS(wxGtkString);
 };
 
+
+// ----------------------------------------------------------------------------
+// list for sorting collated strings
+// ----------------------------------------------------------------------------
+
+#include "wx/vector.h"
+#include "wx/sharedptr.h"
+
+class wxGtkCollatableString
+{
+public:
+    wxGtkCollatableString( const wxString &label, gchar *key )
+    {
+        m_label = label;
+        m_key = key;
+    }
+    
+    ~wxGtkCollatableString()
+    {
+        if (m_key) 
+            g_free( m_key );
+    }
+
+    wxString     m_label;
+    gchar       *m_key;
+};
+
+class wxGtkCollatedArrayString
+{
+public:
+    wxGtkCollatedArrayString() { }
+    
+    int Add( const wxString &new_label )
+    {
+        int index = 0;
+        
+        gchar *new_key_lower = g_utf8_casefold( new_label.utf8_str(), -1); 
+        gchar *new_key = g_utf8_collate_key( new_key_lower, -1); 
+        g_free( new_key_lower );
+        
+        wxSharedPtr<wxGtkCollatableString> new_ptr( new wxGtkCollatableString( new_label, new_key ) );
+    
+        wxVector< wxSharedPtr<wxGtkCollatableString> >::iterator iter;
+        for (iter = m_list.begin(); iter != m_list.end(); ++iter)
+        {
+            wxSharedPtr<wxGtkCollatableString> ptr = *iter;
+            
+            gchar *key = ptr->m_key;
+            if (strcmp(key,new_key) > 0)
+            {
+                m_list.insert( iter, new_ptr );
+                return index;
+            }
+            index ++;
+        }
+        
+        m_list.push_back( new_ptr );
+        return index;
+    }
+    
+    size_t GetCount()
+    {
+        return m_list.size();
+    }
+    
+    wxString At( size_t index )
+    {
+        return m_list[index]->m_label;
+    }
+    
+    void Clear()
+    {
+        m_list.clear();
+    }
+    
+    void RemoveAt( size_t index )
+    {
+        m_list.erase( m_list.begin() + index );
+    }
+    
+private:
+    wxVector< wxSharedPtr<wxGtkCollatableString> > m_list;
+};
+
+
 #endif // _WX_GTK_PRIVATE_STRING_H_
 
diff --git a/src/gtk/choice.cpp b/src/gtk/choice.cpp
index 759985b65b..fc63e3e4e0 100644
--- a/src/gtk/choice.cpp
+++ b/src/gtk/choice.cpp
@@ -75,7 +75,7 @@ bool wxChoice::Create( wxWindow *parent, wxWindowID id,
     {
         // if our m_strings != NULL, Append() will check for it and insert
         // items in the correct order
-        m_strings = new wxSortedArrayString;
+        m_strings = new wxGtkCollatedArrayString;
     }
 
     m_widget = gtk_combo_box_new_text();
@@ -140,9 +140,9 @@ int wxChoice::DoInsertItems(const wxArrayStringsAdapter & items,
         n = pos + i;
         // If sorted, use this wxSortedArrayStrings to determine
         // the right insertion point
-        if(m_strings)
+        if (m_strings)
             n = m_strings->Add(items[i]);
-
+            
         GTKInsertComboBoxTextItem( n, items[i] );
 
         m_clientData.Insert( NULL, n );
diff --git a/src/gtk/combobox.cpp b/src/gtk/combobox.cpp
index 8ff0dc6b79..a0fb1e962d 100644
--- a/src/gtk/combobox.cpp
+++ b/src/gtk/combobox.cpp
@@ -118,7 +118,7 @@ bool wxComboBox::Create( wxWindow *parent, wxWindowID id, const wxString& value,
     }
 
     if (HasFlag(wxCB_SORT))
-        m_strings = new wxSortedArrayString();
+        m_strings = new wxGtkCollatedArrayString();
 
     GTKCreateComboBoxWidget();