From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Mon, 9 Feb 2004 22:30:47 +0000 (+0000)
Subject: don't assert when creating an initially empty wxCB_READONLY combobox
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/b9b8a2b5d79c50af78720589dc96cd7e16cde26e

don't assert when creating an initially empty wxCB_READONLY combobox


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@25693 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/msw/combobox.cpp b/src/msw/combobox.cpp
index 4c07746705..2e6715a7e0 100644
--- a/src/msw/combobox.cpp
+++ b/src/msw/combobox.cpp
@@ -399,7 +399,10 @@ bool wxComboBox::Create(wxWindow *parent, wxWindowID id,
                         validator, name) )
         return FALSE;
 
-    SetValue(value);
+    // we shouldn't call SetValue() for an empty read only combobox as it would
+    // (correctly) thro an assert and is otherwise useless anyhow
+    if ( n || !HasFlag(wxCB_READONLY) )
+        SetValue(value);
 
     // a (not read only) combobox is, in fact, 2 controls: the combobox itself
     // and an edit control inside it and if we want to catch events from this