From: Paul Cornett <paulcor@bullseye.com>
Date: Thu, 2 Nov 2006 18:37:23 +0000 (+0000)
Subject: revert memory leak fix, it causes crash
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/b9060f332453f80bc4c3c6aa6d25f322452d4f5e?ds=inline

revert memory leak fix, it causes crash


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42957 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/gtk/textctrl.cpp b/src/gtk/textctrl.cpp
index 08bb79660b..7443a8f3c9 100644
--- a/src/gtk/textctrl.cpp
+++ b/src/gtk/textctrl.cpp
@@ -1852,8 +1852,8 @@ void wxTextCtrl::Freeze()
             g_object_ref(m_buffer);
             GtkTextBuffer* buf_new = gtk_text_buffer_new(NULL);
             gtk_text_view_set_buffer(GTK_TEXT_VIEW(m_text), buf_new);
-            // gtk_text_view_set_buffer adds its own reference
-            g_object_unref(buf_new);
+            // FIXME: this leaks the new buffer, since gtk_text_view_set_buffer
+            // adds its own reference, but unrefing it here can cause a crash later
         }
     }
 }