From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Mon, 21 Jul 2008 03:39:40 +0000 (+0000)
Subject: don't call gtk_selection_data_set_text() with non-UTF-8 data as we did in ANSI build... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/b82c3e606ca74e6ee5edc5615ee1eaf4b9fd66c8?ds=inline

don't call gtk_selection_data_set_text() with non-UTF-8 data as we did in ANSI build (#2037)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@54742 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/gtk/clipbrd.cpp b/src/gtk/clipbrd.cpp
index 3e64f82515..40b68026a0 100644
--- a/src/gtk/clipbrd.cpp
+++ b/src/gtk/clipbrd.cpp
@@ -299,29 +299,29 @@ selection_handler( GtkWidget *WXUNUSED(widget),
 
     if (size == 0) return;
 
-    void *d = malloc(size);
-    wxON_BLOCK_EXIT1(free, d);
+    wxCharBuffer buf(size);
 
-    // Text data will be in UTF8 in Unicode mode.
-    data->GetDataHere( selection_data->target, d );
+    // text data must be returned in UTF8 if format is wxDF_UNICODETEXT
+    data->GetDataHere( format, buf.data() );
 
-    // NB: GTK+ requires special treatment of UTF8_STRING data, the text
-    //     would show as UTF-8 data interpreted as latin1 (?) in other
-    //     GTK+ apps if we used gtk_selection_data_set()
+    // use UTF8_STRING format if requested in Unicode build but just plain
+    // STRING one in ANSI or if explicitly asked in Unicode
+#if wxUSE_UNICODE
     if (format == wxDataFormat(wxDF_UNICODETEXT))
     {
         gtk_selection_data_set_text(
             selection_data,
-            (const gchar*)d,
+            (const gchar*)buf.data(),
             size );
     }
     else
+#endif
     {
         gtk_selection_data_set(
             selection_data,
             GDK_SELECTION_TYPE_STRING,
             8*sizeof(gchar),
-            (unsigned char*) d,
+            (const guchar*)buf.data(),
             size );
     }
 }