From: Václav Slavík <vslavik@fastmail.fm>
Date: Fri, 1 Feb 2008 23:14:45 +0000 (+0000)
Subject: eliminate code duplication in wxSizer::Fit()
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/7e7bc14b51c0f4441f31be92c214bc93bce0a11d?ds=inline

eliminate code duplication in wxSizer::Fit()

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@51498 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/sizer.cpp b/src/common/sizer.cpp
index eb5eb59bbe..6030fd9f20 100644
--- a/src/common/sizer.cpp
+++ b/src/common/sizer.cpp
@@ -838,6 +838,7 @@ wxSize wxSizer::Fit( wxWindow *window )
 {
     // take the min size by default and limit it by max size
     wxSize size = GetMinClientSize(window);
+    wxSize sizeMax;
 
     wxTopLevelWindow *tlw = wxDynamicCast(window, wxTopLevelWindow);
     if ( tlw )
@@ -848,7 +849,7 @@ wxSize wxSizer::Fit( wxWindow *window )
             // do nothing
             return tlw->GetSize();
         }
-        
+
         // limit the window to the size of the display it is on
         int disp = wxDisplay::GetFromWindow(window);
         if ( disp == wxNOT_FOUND )
@@ -857,40 +858,29 @@ wxSize wxSizer::Fit( wxWindow *window )
             disp = 0;
         }
 
-        wxSize sizeMax = wxDisplay(disp).GetClientArea().GetSize();
-        
+        sizeMax = wxDisplay(disp).GetClientArea().GetSize();
+
         // space for decorations and toolbars etc.
         wxSize tlw_client_size = tlw->GetClientSize();
         wxSize tlw_size = tlw->GetSize();
         sizeMax.x -= tlw_size.x - tlw_client_size.x;
         sizeMax.y -= tlw_size.y - tlw_client_size.y;
-        
-        if ( sizeMax.x != wxDefaultCoord && size.x > sizeMax.x )
-                size.x = sizeMax.x;
-        if ( sizeMax.y != wxDefaultCoord && size.y > sizeMax.y )
-                size.y = sizeMax.y;
-
-        // set client size
-        tlw->SetClientSize( size );
-        
-        // return entire size
-        return tlw->GetSize();
     }
     else
     {
-        wxSize sizeMax = GetMaxClientSize(window);
-        
-        if ( sizeMax.x != wxDefaultCoord && size.x > sizeMax.x )
-                size.x = sizeMax.x;
-        if ( sizeMax.y != wxDefaultCoord && size.y > sizeMax.y )
-                size.y = sizeMax.y;
+        sizeMax = GetMaxClientSize(window);
+    }
 
-        // set client size
-        window->SetClientSize( size );
+    if ( sizeMax.x != wxDefaultCoord && size.x > sizeMax.x )
+            size.x = sizeMax.x;
+    if ( sizeMax.y != wxDefaultCoord && size.y > sizeMax.y )
+            size.y = sizeMax.y;
 
-        // return entire size
-        return window->GetSize();
-    }
+    // set client size
+    window->SetClientSize( size );
+
+    // return entire size
+    return window->GetSize();
 }
 
 void wxSizer::FitInside( wxWindow *window )