From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Mon, 25 May 2009 20:48:57 +0000 (+0000)
Subject: no changes, simply mention a possible misuse of API in a comment (see #60296)
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/7ca19ddbb83f51910a42e3059ceb2bb3c855f48c

no changes, simply mention a possible misuse of API in a comment (see #60296)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@60745 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/msw/timer.cpp b/src/msw/timer.cpp
index e5e42f4a6a..48d24f04d0 100644
--- a/src/msw/timer.cpp
+++ b/src/msw/timer.cpp
@@ -122,6 +122,11 @@ bool wxMSWTimerImpl::Start(int milliseconds, bool oneShot)
     // check that SetTimer() didn't reuse an existing id: according to the MSDN
     // this can happen and this would be catastrophic to us as we rely on ids
     // uniquely identifying the timers because we use them as keys in the hash
+    //
+    // notice that this also happens if the same id is reused for multiple
+    // timers: this used to work in previous versions but was never supported
+    // and absolutely shouldn't be done, use wxID_ANY to assign an id to the
+    // timer automatically or ensure that all your timers have unique ids
     if ( TimerMap().find(m_id) != TimerMap().end() )
     {
         wxLogError(_("Timer creation failed."));