From: Benjamin Williams <bwilliams@kirix.com>
Date: Tue, 6 Nov 2007 14:03:13 +0000 (+0000)
Subject: aui dock renumbering fix
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/7afb5814119f9524161c57e1d8cc0af6cd0b1314

aui dock renumbering fix

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@49683 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/aui/framemanager.cpp b/src/aui/framemanager.cpp
index 7c552d9243..9585b5b242 100644
--- a/src/aui/framemanager.cpp
+++ b/src/aui/framemanager.cpp
@@ -435,13 +435,18 @@ static void RemovePaneFromDocks(wxAuiDockInfoArray& docks,
 // dock has rows with numbers 0,2,5, they will become 0,1,2
 static void RenumberDockRows(wxAuiDockInfoPtrArray& docks)
 {
-    int i, dock_count, j, pane_count;
+    int i, dock_count;
     for (i = 0, dock_count = docks.GetCount(); i < dock_count; ++i)
     {
         wxAuiDockInfo& dock = *docks.Item(i);
         dock.dock_row = i;
-        for (j = 0, pane_count = dock.panes.GetCount(); j < pane_count; ++j)
-            dock.panes.Item(j)->dock_row = i;
+        
+        // (BIW) I believe these lines are wrong because they are modifying
+        // the original pane structures, which should be avoided as much
+        // as possible.
+        
+        //for (j = 0, pane_count = dock.panes.GetCount(); j < pane_count; ++j)
+        //    dock.panes.Item(j)->dock_row = i;
     }
 }