From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Wed, 12 Sep 2007 00:39:21 +0000 (+0000)
Subject: check that the conversion really succeeds even when wxMBConv_win32::WC2MB() is called... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/765bdb4a1b5954c1382a3fbdf2c82fd8d86edb3f

check that the conversion really succeeds even when wxMBConv_win32::WC2MB() is called with NULL buffer

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@48643 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/common/strconv.cpp b/src/common/strconv.cpp
index 609f44b9d1..91186b40c6 100644
--- a/src/common/strconv.cpp
+++ b/src/common/strconv.cpp
@@ -2426,26 +2426,36 @@ public:
             return wxCONV_FAILED;
         }
 
-        // if we were really converting, check if we succeeded
-        if ( buf )
+        // we did something, check if we really succeeded
+        if ( flags )
         {
-            if ( flags )
+            // check if the conversion failed, i.e. if any replacements
+            // were done
+            if ( usedDef )
+                return wxCONV_FAILED;
+        }
+        else // we must resort to double tripping...
+        {
+            // first we need to ensure that we really have the MB data: this is
+            // not the case if we're called with NULL buffer, in which case we
+            // need to do the conversion yet again
+            wxCharBuffer bufDef;
+            if ( !buf )
             {
-                // check if the conversion failed, i.e. if any replacements
-                // were done
-                if ( usedDef )
+                bufDef = wxCharBuffer(len);
+                buf = bufDef.data();
+                if ( !::WideCharToMultiByte(m_CodePage, flags, pwz, -1,
+                                            buf, len, NULL, NULL) )
                     return wxCONV_FAILED;
             }
-            else // we must resort to double tripping...
+
+            wxWCharBuffer wcBuf(n);
+            if ( MB2WC(wcBuf.data(), buf, n) == wxCONV_FAILED ||
+                    wcscmp(wcBuf, pwz) != 0 )
             {
-                wxWCharBuffer wcBuf(n);
-                if ( MB2WC(wcBuf.data(), buf, n) == wxCONV_FAILED ||
-                        wcscmp(wcBuf, pwz) != 0 )
-                {
-                    // we didn't obtain the same thing we started from, hence
-                    // the conversion was lossy and we consider that it failed
-                    return wxCONV_FAILED;
-                }
+                // we didn't obtain the same thing we started from, hence
+                // the conversion was lossy and we consider that it failed
+                return wxCONV_FAILED;
             }
         }