From: Stefan Csomor <csomor@advancedconcepts.ch>
Date: Fri, 20 Oct 2006 06:04:12 +0000 (+0000)
Subject: cleaning up the runloop source properly (was causing crashes in embedded situations... 
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/7113b61aafa54069d001695b1ad314f65a619631

cleaning up the runloop source properly (was causing crashes in embedded situations, as the runloop source persisted)


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@42144 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/src/mac/carbon/app.cpp b/src/mac/carbon/app.cpp
index 2128892511..e997cc3e1b 100644
--- a/src/mac/carbon/app.cpp
+++ b/src/mac/carbon/app.cpp
@@ -850,6 +850,8 @@ bool wxApp::Initialize(int& argc, wxChar **argv)
     event_posted_context.perform = macPostedEventCallback;
     m_macEventPosted = CFRunLoopSourceCreate(NULL,0,&event_posted_context);
     CFRunLoopAddSource(CFRunLoopGetCurrent(), m_macEventPosted, kCFRunLoopCommonModes);
+	// run loop takes ownership
+	CFRelease(m_macEventPosted);
 #endif
 
     UMAShowArrowCursor() ;
@@ -908,8 +910,10 @@ void wxApp::CleanUp()
 
 #ifdef __WXMAC_OSX__
     if (m_macEventPosted)
-        CFRelease(m_macEventPosted);
-    m_macEventPosted = NULL;
+	{
+		CFRunLoopRemoveSource(CFRunLoopGetCurrent(), m_macEventPosted, kCFRunLoopCommonModes);
+		m_macEventPosted = NULL;
+	}
 #endif
 
     // One last chance for pending objects to be cleaned up