From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sun, 23 Jun 2013 16:39:15 +0000 (+0000)
Subject: No real changes, just simplify wxBookCtrlBase unit test a little.
X-Git-Url: https://git.saurik.com/wxWidgets.git/commitdiff_plain/6f71e062428e8a74763eee7fb85d04ea24a70988

No real changes, just simplify wxBookCtrlBase unit test a little.

Add Realize() virtual function that can be overridden in ToolbookTestCase
instead of using explicit wxDynamicCasts.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@74278 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---

diff --git a/tests/controls/bookctrlbasetest.cpp b/tests/controls/bookctrlbasetest.cpp
index c28e238a68..c5065607e2 100644
--- a/tests/controls/bookctrlbasetest.cpp
+++ b/tests/controls/bookctrlbasetest.cpp
@@ -17,8 +17,6 @@
 #include "wx/artprov.h"
 #include "wx/imaglist.h"
 #include "wx/bookctrl.h"
-#include "wx/toolbook.h"
-#include "wx/toolbar.h"
 #include "bookctrlbasetest.h"
 #include "testableframe.h"
 
@@ -35,11 +33,7 @@ void BookCtrlBaseTestCase::AddPanels()
 
     base->AssignImageList(m_list);
 
-    //We need to realize the toolbar if we ware running the wxToolbook tests
-    wxToolbook *book = wxDynamicCast(base, wxToolbook);
-
-    if(book)
-        book->GetToolBar()->Realize();
+    Realize();
 
     m_panel1 = new wxPanel(base);
     m_panel2 = new wxPanel(base);
@@ -96,11 +90,7 @@ void BookCtrlBaseTestCase::PageManagement()
 
     base->InsertPage(0, new wxPanel(base), "New Panel", true, 0);
 
-    //We need to realize the toolbar if we ware running the wxToolbook tests
-    wxToolbook *book = wxDynamicCast(base, wxToolbook);
-
-    if(book)
-        book->GetToolBar()->Realize();
+    Realize();
 
     CPPUNIT_ASSERT_EQUAL(0, base->GetSelection());
     CPPUNIT_ASSERT_EQUAL(4, base->GetPageCount());
diff --git a/tests/controls/bookctrlbasetest.h b/tests/controls/bookctrlbasetest.h
index b72a5b47c2..2fec1e293a 100644
--- a/tests/controls/bookctrlbasetest.h
+++ b/tests/controls/bookctrlbasetest.h
@@ -48,6 +48,9 @@ protected:
     //the ctrl.
     void AddPanels();
 
+    // Override this to call Realize() on the toolbar in the wxToolbook test.
+    virtual void Realize() { }
+
     wxPanel* m_panel1;
     wxPanel* m_panel2;
     wxPanel* m_panel3;
diff --git a/tests/controls/toolbooktest.cpp b/tests/controls/toolbooktest.cpp
index b1b0802bf2..58b8f535ba 100644
--- a/tests/controls/toolbooktest.cpp
+++ b/tests/controls/toolbooktest.cpp
@@ -41,6 +41,8 @@ private:
     virtual wxEventType GetChangingEvent() const
     { return wxEVT_TOOLBOOK_PAGE_CHANGING; }
 
+    virtual void Realize() { m_toolbook->GetToolBar()->Realize(); }
+
     CPPUNIT_TEST_SUITE( ToolbookTestCase );
         wxBOOK_CTRL_BASE_TESTS();
         CPPUNIT_TEST( ToolBar );